Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRESOLVER-443] Integrate tool into build #385

Merged
merged 2 commits into from Dec 11, 2023

Conversation

cstamas
Copy link
Member

@cstamas cstamas commented Dec 4, 2023

Simply invoke it as very last step of build to generate the documentation. Ideally, this will produce same output hence there will be no side effect (no local change). But in case page is outdated (needs update) the local checkout becomes dirty and would prevent release for example.

This is not "final" solution, but would work IMHO. Current issue with tool is that:

  • it must have access to up-to-date class files (to javap them), hence it runs as last module of multi module build
  • it must process WHOLE project, so to say "aggregate" output, it cannot run per module

https://issues.apache.org/jira/browse/MRESOLVER-443

Simply invoke it as very last step of build to generate the
documentation. Ideally, this will produce _same output_ hence
there will be no side effect. But in case page is outdated
the local checkout becomes dirty and would prevent release.

---

https://issues.apache.org/jira/browse/MRESOLVER-443
@cstamas cstamas self-assigned this Dec 4, 2023
@cstamas cstamas added this to the 2.0.0 milestone Dec 5, 2023
@cstamas
Copy link
Member Author

cstamas commented Dec 8, 2023

@michael-o anything to add here?

@cstamas cstamas merged commit 5e2ae01 into apache:master Dec 11, 2023
7 checks passed
@cstamas cstamas deleted the MRESOLVER-443 branch December 11, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant