Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRESOLVER-461] Cleanup in dep managers #402

Merged
merged 7 commits into from Dec 20, 2023
Merged

Conversation

cstamas
Copy link
Member

@cstamas cstamas commented Dec 19, 2023

3 of them were almost same.

  • default: derives to infinity, always applies
  • transitive: derives to infinity, applies after depth>=2
  • classic: derives until depth>=2, applies after depth>=2

Note: "derives" means picks up depMgt from currently processed node. Hence, classic ignores all depMgt in graph coming from transitive dependencies. depth=1 is root (ie. project), depth=2 are first level deps (those listed in POM), etc.


https://issues.apache.org/jira/browse/MRESOLVER-461

@cstamas cstamas self-assigned this Dec 19, 2023
@michael-o
Copy link
Member

There is no logical change, but only pulled up to a super class?

@cstamas
Copy link
Member Author

cstamas commented Dec 20, 2023

Yes, a cleanup

@cstamas
Copy link
Member Author

cstamas commented Dec 20, 2023

thing is: will do resolver - maven - IT run to test classic, but other two was never tested (so i can be only certain did not break them). Will also add UTs as only classic has rudimentary one

@cstamas
Copy link
Member Author

cstamas commented Dec 20, 2023

OK, the resolver master - maven master - maven IT master ran OK, so this shows that "classic" was undisturbed.

Next will do UTs and will merge this as I have your approvals.

@cstamas
Copy link
Member Author

cstamas commented Dec 20, 2023

Removed ClassicDependencyManagerTest and added new DependencyManagerTest UT tests all 3 of implementations (all aspects, not only Optional as Classic UT did) with comments sprinkled explaining what they do.

@cstamas cstamas merged commit b8e9f9f into apache:master Dec 20, 2023
4 checks passed
@cstamas cstamas deleted the MRESOLVER-461 branch December 20, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants