[MRESOLVER-491] Resolver should not have any "predefined" scope #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is duty of consumer application to define those. Also, no need for SPI either, as essentialy ONLY the dependency managers were using the "system" scope definition so far. Now, client code, that instantianates these anyway are able to pass in predicate. --- https://issues.apache.org/jira/browse/MRESOLVER-491
gnodet
reviewed
Feb 6, 2024
...st/java/org/eclipse/aether/internal/impl/collect/DependencyCollectorDelegateTestSupport.java
Outdated
Show resolved
Hide resolved
slawekjaranowski
approved these changes
Feb 6, 2024
gnodet
reviewed
Feb 7, 2024
...resolver-util/src/test/java/org/eclipse/aether/util/graph/manager/DependencyManagerTest.java
Outdated
Show resolved
Hide resolved
gnodet
approved these changes
Feb 7, 2024
|
@gnodet looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is duty of consumer application to define those. Also, no need for SPI either, as essentialy ONLY the dependency managers were using the "system" scope definition so far.
Now, client code, that instantianates these anyway are able to pass in predicate.
Note: as util is japicmp checked, the def ctors MUST stay, but are deprecated.
https://issues.apache.org/jira/browse/MRESOLVER-491