[MRESOLVER-536] Followup change: log failures #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not swallow cases like AccessDeniedEx, and log failures. --- https://issues.apache.org/jira/browse/MRESOLVER-536
rmannibucau
approved these changes
Apr 16, 2024
|
ping @Jurrie I know you are targeting 1.9.x but just FYI |
michael-o
requested changes
Apr 16, 2024
| if (e instanceof AccessDeniedException) { | ||
| throw e; | ||
| } | ||
| logger.debug("Failed to set last-modified: {}", path, e); |
There was a problem hiding this comment.
I think this should be even on trace because it can be very verbose....
| if (e instanceof AccessDeniedException) { | ||
| throw e; | ||
| } | ||
| logger.debug("Failed to set last-modified: {}", path, e); |
There was a problem hiding this comment.
"Failed to set last modified date: {}"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not swallow cases like AccessDeniedEx, and log failures. Make new method
voidas nothing is interested in return value, while all we wanted (swallow some and log) is handled here.This PR builds upon prev PR #468
https://issues.apache.org/jira/browse/MRESOLVER-536