apply feedback from PR review

apache · Jul 19, 2022 · 14e6517 · 14e6517
1 parent 461d9c8
commit 14e6517
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 5 deletions.
diff --git a/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/pom.xml b/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/pom.xml
@@ -35,6 +35,9 @@
     see http://eclipse.org/jgit/
   </description>
 
+  <properties>
+    <jgitVersion>5.13.1.202206130422-r</jgitVersion><!-- version 6+ requires Java 11 -->
+  </properties>
   <dependencies>
     <dependency>
       <groupId>javax.inject</groupId>
@@ -47,12 +50,12 @@
     <dependency>
       <groupId>org.eclipse.jgit</groupId>
       <artifactId>org.eclipse.jgit</artifactId>
-      <version>5.13.1.202206130422-r</version><!-- since version 6 requires Java 11 -->
+      <version>${jgitVersion}</version>
     </dependency>
     <dependency>
       <groupId>org.eclipse.jgit</groupId>
       <artifactId>org.eclipse.jgit.ssh.apache</artifactId>
-      <version>5.13.1.202206130422-r</version><!-- since version 6 requires Java 11 -->
+      <version>${jgitVersion}</version>
     </dependency>
     <dependency>
       <groupId>org.slf4j</groupId>

diff --git a/...ain/java/org/apache/maven/scm/provider/git/jgit/command/checkout/JGitCheckOutCommand.java b/...ain/java/org/apache/maven/scm/provider/git/jgit/command/checkout/JGitCheckOutCommand.java
@@ -112,7 +112,7 @@ protected CheckOutScmResult executeCheckOutCommand( ScmProviderRepository repo,
             }
 
             TransportConfigCallback transportConfigCallback = new JGitTransportConfigCallback(
-                sshSessionFactorySupplier.apply ( (GitScmProviderRepository) repo, logger ) );
+                sshSessionFactorySupplier.apply( (GitScmProviderRepository) repo, logger ) );
 
             logger.debug( "try checkout of branch: " + branch );
 

diff --git a/...it/src/main/java/org/apache/maven/scm/provider/git/jgit/command/list/JGitListCommand.java b/...it/src/main/java/org/apache/maven/scm/provider/git/jgit/command/list/JGitListCommand.java
@@ -81,7 +81,7 @@ protected ListScmResult executeListCommand( ScmProviderRepository repo, ScmFileS
             Collection<Ref> lsResult = git.lsRemote().setCredentialsProvider( credentials )
                     .setTransportConfigCallback(
                             new JGitTransportConfigCallback( 
-                                sshSessionFactorySupplier.apply ( (GitScmProviderRepository) repo, logger ) ) )
+                                sshSessionFactorySupplier.apply( (GitScmProviderRepository) repo, logger ) ) )
                     .call();
             for ( Ref ref : lsResult )
             {

diff --git a/...java/org/apache/maven/scm/provider/git/jgit/command/remoteinfo/JGitRemoteInfoCommand.java b/...java/org/apache/maven/scm/provider/git/jgit/command/remoteinfo/JGitRemoteInfoCommand.java
@@ -80,7 +80,7 @@ public RemoteInfoScmResult executeRemoteInfoCommand( ScmProviderRepository repos
             LsRemoteCommand lsCommand =
                 git.lsRemote().setRemote( repo.getPushUrl() ).setCredentialsProvider( credentials )
                         .setTransportConfigCallback( 
-                            new JGitTransportConfigCallback( sshSessionFactorySupplier.apply ( repo, logger ) )
+                            new JGitTransportConfigCallback( sshSessionFactorySupplier.apply( repo, logger ) )
                         );
 
             Map<String, String> tag = new HashMap<>();