[SCM-937] replace deprecated methods

[elharo]

@eolivelli

[michael-o]

We should create another issue here because it is subject to character conversion.

[elharo]

good point. fixed.

[elharo]

Seeing some flakiness in our windows builds for this plugin in multiple PRs:

Error Message

Command failed.The svn tag command failed.

Stacktrace

org.apache.maven.plugin.MojoExecutionException: Command failed.The svn tag command failed.
at org.apache.maven.scm.plugin.TagMojoTest.testTag(TagMojoTest.java:93)

Standard Output

Test command line: cmd.exe /X /C "svnadmin create repository"
[INFO] Removing F:\jenkins\jenkins-slave\workspace\maven-box_maven-scm_i937\m\maven-scm-plugin\target\checkout
[INFO] Executing: cmd.exe /X /C "svn --non-interactive checkout file:///F:/jenkins/jenkins-slave/workspace/maven-box_maven-scm_i937/m/maven-scm-plugin/target/repository/trunk@ F:\jenkins\jenkins-slave\workspace\maven-box_maven-scm_i937\m\maven-scm-plugin\target\checkout"
[INFO] Working directory: F:\jenkins\jenkins-slave\workspace\maven-box_maven-scm_i937\m\maven-scm-plugin\target
[INFO] Final Tag Name: 'mytag'
[INFO] Executing: cmd.exe /X /C "svn --non-interactive copy --file C:\Windows\system32\config\systemprofile\AppData\Local\Temp\maven-scm-173513893.commit --encoding UTF-8 --parents . file:///F:/jenkins/jenkins-slave/workspace/maven-box_maven-scm_i937/m/maven-scm-plugin/target/repository/tags/mytag@"
[INFO] Executing: cmd.exe /X /C "svn --non-interactive copy --file C:\Windows\system32\config\systemprofile\AppData\Local\Temp\maven-scm-173513893.commit --encoding UTF-8 --parents . file:///F:/jenkins/jenkins-slave/workspace/maven-box_maven-scm_i937/m/maven-scm-plugin/target/repository/tags/mytag@"
[INFO] Working directory: F:\jenkins\jenkins-slave\workspace\maven-box_maven-scm_i937\m\maven-scm-plugin\target\checkout
[INFO] Working directory: F:\jenkins\jenkins-slave\workspace\maven-box_maven-scm_i937\m\maven-scm-plugin\target\checkout
[ERROR] Provider message:
[ERROR] The svn tag command failed.
[ERROR] Command output:
[ERROR] svn: E720003: Can't open file 'C:\Windows\system32\config\systemprofile\AppData\Local\Temp\maven-scm-173513893.commit': The system cannot find the path specified.

[michael-o]

This cannot be real: C:\Windows\system32\config\systemprofile\AppData\Local\Temp\maven-scm-173513893.commit

Writing into C:\Windows is just wrong. I have this dir on my machine: C:\WINDOWS\System32\config\systemprofile\AppData. It seems like Jenkins runs a some system account. Temp does not exist.
There it is: https://superuser.com/a/598626
We need to file an issue with INFRA to create the Temp dir. After that the test should pass.

[michael-o]

I don't know whether this is better. If we read from stdin or the stdin has been redirected and the encoding was not UTF-8 and did contain multibyte characters the reader will show errors.

[elharo]

#99 to update Plexus didn't flake, so possibly the plexus-utils update there fixes this?

[michael-o]

#99 to update Plexus didn't flake, so possibly the plexus-utils update there fixes this?

I don't think. It might be node specific that Temp does exist. I would still inquire with INFRA first.

[elharo]

If it's the Temp directory that's at fault, there might be a way to avoid that.

[michael-o]

If it's the Temp directory that's at fault, there might be a way to avoid that.

What is your proposal then?