[MSHADE-223] - Endless processing with promoteTransitiveDependencies

[dmitri-gb]

Fix the endless processing that was caused by not checking the classifier of the dependencies when adding excludes.

I opted for just comparing the results of the getId method, as it already contains all the necessary info (groupId + artifactId + type + classifier). The previous check dep.getType() == null seems unnecessary, as the type is generally never null.

I also added an integration test that reproduces the issue. It includes an invoker.properties file that sets invoker.timeoutInSeconds=60, because without the fix the issue manifests as a non-terminating build.

PS. This fix likely also addresses the complaints that have been filed under MSHADE-148 after its closure.

• I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004

[xhumanoid]

@khmarbaise @rmannibucau

Hi, any updates when it will merged?

without this fix we have infinity loops with 2 artifact but different classifiers

        <dependency>
            <groupId>groupId</groupId>
            <artifactId>artifactId</artifactId>
            <version>0.0.1</version>
            <scope>test</scope>
        </dependency>
        <dependency>
            <groupId>groupId</groupId>
            <artifactId>artifactId</artifactId>
            <version>0.0.1</version>
            <classifier>tests</classifier>
            <scope>test</scope>
        </dependency>

[rmannibucau]

LGTM, i dont have a computer handy but no blocker to merge it in the week for me

[rfscholte]

Fixed with 038d807 and be330db
Thanks for the PR!