[MSHARED-750] - Unbalanced quotes in command with escaped double quot… #4
Conversation
| } | ||
| else if ( "\"".equals( nextTok ) ) | ||
| { | ||
| state = inDoubleQuote; | ||
| if ( inEscape ) |
There was a problem hiding this comment.
If anyone has a tidier way to do this, it would be much appreciated!
| } | ||
|
|
||
| private Process exec(String cmd) throws CommandLineException, InterruptedException { |
There was a problem hiding this comment.
Removed these tests as they seemed to always return 0, even when the exception was thrown. However, they might be useful because they run on the system rather than just testing the setup?
|
Is this ready for integration from your side ? |
|
Yep! As soon as you're happy with it. |
|
So lets see what CI says... https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven-shared-utils/job/MSHARED-750/ |
|
Successful build. Also merged into master
Thanks for your contribution. |
|
Was the email better this time? |
|
Hi Kathryn, If you look on the repository on master you see the your image ...which means GitHub has identified it correctly..Thanks for fixing this... |
…ation mark