[MSITE-872] Set the Content-Type header #48
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elharo
requested changes
Apr 24, 2021
src/main/java/org/apache/maven/plugins/site/run/DoxiaFilter.java
Outdated
Show resolved
Hide resolved
elharo
reviewed
Apr 25, 2021
src/main/java/org/apache/maven/plugins/site/run/DoxiaFilter.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/maven/plugins/site/run/DoxiaFilter.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/maven/plugins/site/run/DoxiaFilter.java
Outdated
Show resolved
Hide resolved
|
Tests are needed : I need to first start the jetty server (mvn site:run) then make a simple GET http call, then stop the jetty server. Is there a similar Integration Test in the project ? |
michael-o
reviewed
Apr 26, 2021
src/main/java/org/apache/maven/plugins/site/run/DoxiaFilter.java
Outdated
Show resolved
Hide resolved
|
I think this could be tested as a unit test that invokes the method directly and confirms the response. |
See https://issues.apache.org/jira/browse/MSITE-872 Set the ContentType to the Response
michael-o
reviewed
Apr 26, 2021
src/main/java/org/apache/maven/plugins/site/run/DoxiaFilter.java
Outdated
Show resolved
Hide resolved
elharo
reviewed
Apr 26, 2021
src/main/java/org/apache/maven/plugins/site/run/DoxiaFilter.java
Outdated
Show resolved
Hide resolved
src/test/java/org/apache/maven/plugins/site/run/SiteRunMSITE872Test.java
Outdated
Show resolved
Hide resolved
src/test/java/org/apache/maven/plugins/site/run/SiteRunMSITE872Test.java
Show resolved
Hide resolved
src/test/java/org/apache/maven/plugins/site/run/SiteRunMSITE872Test.java
Outdated
Show resolved
Hide resolved
src/test/java/org/apache/maven/plugins/site/run/SiteRunMSITE872Test.java
Outdated
Show resolved
Hide resolved
Clean code
Two possible results according to the OS / version
3 possible mimetypes pour javascript
|
Tested ok in standalone mode and ok in the CI chain |
|
The test looks convoluted to me. Why not fire up Jetty, and get the |
|
Could someone help me in creating such a test, is there an example ? Thanks |
|
This PR isn't good. I have a decent one locally. Will commit soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the header Content-Type according to the file extension
See https://issues.apache.org/jira/browse/MSITE-872