Change code style to refer to the one from maven-shared-resources

[gnodet]

PR following up apache/maven-shared-resources#1 to use a single reference for code style formatting.

[cstamas]

Maybe point the download links to ASF gitbox instead of a "just a mirror" GH?

[slawekjaranowski]

Link is for eclipse-formatter-config.xml

[gnodet]

@slawekjaranowski YES ! A single file is used. The recent versions of IDEA allow importing eclipse config files 😀

[slawekjaranowski]

I don't see such options:

IntelliJ IDEA 2022.2.2 (Ultimate Edition)

[cstamas]

[cstamas]

But this is NOT a "latest" IDEA feature at all, it is since a while, that IDEA supports eclipse XML import....

[gnodet]

Same as @cstamas on 2022.2.1 Community Edition

[gnodet]

[cstamas]

This is supported since 2014 it seems https://blog.jetbrains.com/idea/2014/01/intellij-idea-13-importing-code-formatter-settings-from-eclipse/

[cstamas]

@slawekjaranowski Eclipse Interoperability plugin disabled maybe? (by default is enabled, unless you tampered with it)

[gnodet]

[gnodet]

Btw, given we enforce a 120 characters hard break on lines, I wonder if we should switch to header formatted in the same way, something like

/*
 * Licensed to the Apache Software Foundation (ASF) under one or more contributor license 
 * agreements. See the NOTICE file distributed with this work for additional information 
 * regarding copyright ownership. The ASF licenses this file to you under the Apache License, 
 * Version 2.0 (the "License"); you may not use this file except in compliance with the 
 * License. You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software distributed under the 
 * License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, 
 * either express or implied. See the License for the specific language governing permissions 
 * and limitations under the License.
 */

[slawekjaranowski]

@cstamas Eclipse Interoperability helps 😄

[slawekjaranowski]

I tested importing importing eclipse formats ... into InteliJ,
We have missing configurations for:

• imports order - settings -> Code Style -> Java - imports tab has default values

how we will manage it?

[slawekjaranowski]

We should mention that plugin Eclipse Interoperability must be enable.

[gnodet]

I tested importing importing eclipse formats ... into InteliJ, We have missing configurations for:

• imports order - settings -> Code Style -> Java - imports tab has default values

how we will manage it?

Meh, you're right.

We could tell users that imports won't be sorted and that they need to either add those or rely on the impsort plugin wich will fix those.

Alternatively, we can add back idea settings, but I'd rather avoid it. We can generate it by importing the eclipse settings into IDEA, fix the import settings to comply with maven code style and export those settings. But we'd have to put them in maven-shared-resources also I suppose.

[slawekjaranowski]

I tested importing importing eclipse formats ... into InteliJ, We have missing configurations for:

• imports order - settings -> Code Style -> Java - imports tab has default values

how we will manage it?

Meh, you're right.

We could tell users that imports won't be sorted and that they need to either add those or rely on the impsort plugin wich will fix those.

Alternatively, we can add back idea settings, but I'd rather avoid it. We can generate it by importing the eclipse settings into IDEA, fix the import settings to comply with maven code style and export those settings. But we'd have to put them in maven-shared-resources also I suppose.

I'm for preserve native settings for InteliJ, it can be in m-shared-r.
I hope that not will be changed so frequently, so we can do such manual works as you describe, to have synchronized Eclipse and InteliJ.

It will be easier for user to simply import settings.

We have also import settings for eclipse in https://github.com/apache/maven-site/blob/master/content/resources/developers/maven-eclipse.importorder so this file should be moved to shared to have everything in one place.