Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using an SPDX identifier as the license name in example #351

Merged
merged 1 commit into from
Dec 13, 2022

Conversation

slawekjaranowski
Copy link
Member

According to recommendation a few lines below

According to recommendation a few lines below
Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at https://spdx.org/licenses/ it differentiates between name and id. Here, we abuse our name as id. I consider this to be logically wrong.

@slawekjaranowski
Copy link
Member Author

Looking at https://spdx.org/licenses/ it differentiates between name and id. Here, we abuse our name as id. I consider this to be logically wrong.

We have text:

Using an https://spdx.org/licenses/}SPDX identifier as the license name is recommended.

So how should be ...

I merged similar in ASF parent pom 😄

@michael-o
Copy link
Member

Looking at https://spdx.org/licenses/ it differentiates between name and id. Here, we abuse our name as id. I consider this to be logically wrong.

We have text:

Using an https://spdx.org/licenses/}SPDX identifier as the license name is recommended.

So how should be ...

I merged similar in ASF parent pom 😄

I know that we have it and only because we don't have an id element. For me, it feels wrong, honestly, but I won't object to merge it.

@kwin
Copy link
Member

kwin commented Dec 13, 2022

For me id is more useful than an arbitrary label. Therefore I think we should stick to using an id in the name element (although the naming of the element is unfortunate)

@michael-o
Copy link
Member

For me id is more useful than an arbitrary label. Therefore I think we should stick to using an id in the name element (although the naming of the element is unfortunate)

Real men don't wear clothes with labels, they have custom-tailored.

@slawekjaranowski slawekjaranowski merged commit 598dd02 into master Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants