Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUREFIRE-790 Added support for execution context propagation #2

Closed
wants to merge 1 commit into from

Conversation

kpiwko
Copy link

@kpiwko kpiwko commented Nov 15, 2011

No description provided.

@marcusholl
Copy link

We also need the possibility to use the settings file with the active profiles from a surrounding maven call inside a maven process forked by surefire via the org.apache.maven.it.Verifier. This is from my point of view a valid use case which is currently apparently not supported.
For build systems it is quite usual to use dedicated local repositories defined via -Dmaven.repo.local on the command line of the outermost maven call. Maybe you should consider to hand over that property also.

asfgit pushed a commit that referenced this pull request Dec 14, 2012
instead mvn site-deploy

BTW, this has others advantages:
- easier to understand (it's a local site staging, not a site deployment
to remote hosting)
- the distributionManagement entry has the real value, not a temporary
local storage location (which appears in Distribution Management report)
@gastaldi
Copy link
Member

gastaldi commented Jul 1, 2014

I think the default value for executionContextNamespace should be: org.apache.maven

@Tibor17
Copy link
Contributor

Tibor17 commented Sep 23, 2015

@kpiwko
@gastaldi
@marcusholl
What can we do about this old issue?
My suggestion is to propose SPI in Surefire 3.x where hacking system properties in forked jvm would be fetched right from plugin process.
I want to have groovy scripting with interfaces in Surefire API instead of SPI. The interfaces will be compiled in Java 8 unlike most of other surefire modules compiled in Java 6.

@kpiwko
Copy link
Author

kpiwko commented Sep 24, 2015

@Tibor17 SPI would work for me. Basically any means how to get the information about Maven process to forked JVM would be helpful, if enabled by default, even better.

@Tibor17
Copy link
Contributor

Tibor17 commented Sep 24, 2015

Enabled by default would mean to introduce a new feature and new bugs and
requirements in Jira.
The reason why we want the users to implement the API in their own is to
get freedom in Jira and solve contradictory issues.
It's pragmatic decision from our side. I understand that users would prefer
us to implement but we have limited resources.

On Thu, Sep 24, 2015 at 8:53 AM, Karel Piwko notifications@github.com
wrote:

@Tibor17 https://github.com/Tibor17 SPI would work for me. Basically
any means how to get the information about Maven process to forked JVM
would be helpful, if enabled by default, even better.


Reply to this email directly or view it on GitHub
#2 (comment).

Cheers
Tibor

@Tibor17 Tibor17 closed this Jun 8, 2019
jon-bell added a commit to jon-bell/maven-surefire that referenced this pull request Dec 19, 2019
[Surefire-1516] Improve IPC performace with Sockets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants