[SUREFIRE-1222] ForkClient attempts to consume unrelated lines #210
Conversation
|
@eolivelli |
|
We should not forget that the following branch [1] is part of interprocess communication. The TestNG Suites should be determined by type, either XML, File or array. This includes tests which should precisely specify what is sent, either a class or a suite and type. This would mean that Surefire will be Open-Closed Principle together with plugin Extensions and the user can write his own Booter. |
There was a problem hiding this comment.
@Tibor17 this branch does not compile
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project surefire-api: Compilation failure: Compilation failure:
[ERROR] /home/eolivelli/dev/maven-surefire/surefire-api/src/main/java/org/apache/maven/surefire/booter/CommandReader.java:[53,1] cannot find symbol
[ERROR] symbol: static encodeStringForForkCommunication
[ERROR] location: class
[ERROR] /home/eolivelli/dev/maven-surefire/surefire-api/src/main/java/org/apache/maven/surefire/booter/ForkingRunListener.java:[42,1] cannot find symbol
[ERROR] symbol: static escapeToPrintable
[ERROR] location: class
[ERROR] /home/eolivelli/dev/maven-surefire/surefire-api/src/main/java/org/apache/maven/surefire/booter/ForkingRunListener.java:[41,1] cannot find symbol
.......
| * <p/> | ||
| * | ||
| * @author <a href="mailto:tibordigana@apache.org">Tibor Digana (tibor17)</a> | ||
| * @since 2.20.1 |
There was a problem hiding this comment.
@Tibor17 we will have to change all of these comments
|
|
||
| private void encodeAndPrintEvent( StringBuilder command ) | ||
| { | ||
| byte[] array = command.append( '\n' ).toString().getBytes( streamCharset ); |
There was a problem hiding this comment.
it is better to write the length of the command and then the command and do not rely on a separator
| encodeBytes = new byte[len]; | ||
| arraycopy( buf, off, encodeBytes, 0, len ); | ||
| } | ||
| return encodeMessage( operation, runMode, bufEncoding, printBase64Binary( encodeBytes ) ); |
There was a problem hiding this comment.
in general I would prefer to use framing ( length + payload) instead of encoding with base64
This way the protocol is much efficient and most of the data flow thru the socket without modifications (with a sniffer is easier to perform debug).
on the reader's side you can pre-allocate buffers and do very useful things with framing
This is a WIP pull request, to help reviews on the branch for
https://issues.apache.org/jira/browse/SUREFIRE-1222