Refer to correct property in skipping-tests doc

[qerub]

I found a little error when reading https://maven.apache.org/surefire/maven-failsafe-plugin/examples/skipping-tests.html :

You can also skip the tests via the command line by executing the following command:

mvn install -DskipITs

Since skipTests is also supported by the Surefire Plugin, this will have the effect of not running any tests. If, instead, you want to skip only the integration tests being run by the Failsafe Plugin, you would use the skipITs property instead:

mvn install -DskipITs

The former command should refer to skipTests instead.

[Tibor17]

This is a misunderstanding because skipTests is meant to be related to the unit tests and thus the maven-surefire-plugin. We know that skipTests is also utilized by maven-failsafe-plugin but that's wrong design which was confirmed by the emeritus developers of surefire. The problem with this design is the fact that you are not able to skip unit tests and ITs totally separatelly. So it is worth not to present this detail in the documentation and it is worth to recommend using skipITs for maven-failsafe-plugin and consider the skipTests in maven-failsafe-plugin as a design issue. We have a JIRA ticket for this incident.

[eolivelli]

LGTM

[qerub]

I think we're mixing up three different issues here:

1. what the author of the current documentation had in mind when they wrote it.
2. the general state of the current documentation (that IMHO should describe current behavior even if it's bad).
3. the current behavior of the plugin (w.r.t. skipTests).

This mini-PR only addresses point 1. Working on 2 doesn't seem valuable until 3 has been resolved.

[Tibor17]

The author of the doc separated the text been dedicated to the Surefire and Failsafe plugin using IF-ELSE decision making in one doc file. That's the (1). We do not copy the doc from Surefire module to the Failsafe module and we only switch few lines of text which is maybe 10%.

The consequence of this PR is (2) and that means the we will have a big problem to split skipping Surefire tests and Failsafe test in the future. This is the impact I can see with this PR. The goal should be to have two properties.

Since the Maven knows only Surefire bound to the phase test by default and the Failsafe is not bound to any phase, it's the property skipTests which should stick only to Surefire and unit tests. The Failsafe has skipITs property and the bug is with skipTests been used in Failsafe. Removing skipTests from the logic in Failsafe would isolate both plugins and the impact in the community will be small because we have cca 25% of Failsafe users and Surefire has 75% users. Some users asked me for providing a common property skipping both plugins but we do not have to introduce it because the property exists maven.test.skip.exec.

[qerub]

The author of the doc separated the text been dedicated to the Surefire and Failsafe plugin using IF-ELSE decision making in one doc file. That's the (1). We do not copy the doc from Surefire module to the Failsafe module and we only switch few lines of text which is maybe 10%.

The docs are separated using IF-ELSE but the author of the current documentation clearly wanted to document both skipITs (firstly) and skipTests. This is the section in its entirety:

  To skip running the tests for a particular project, set the <<skipITs>> property to <<true>>.
 
 +---+
 […long example with <skipITs>true</skipITs>…]
 +---+
 
  You can also skip the tests via the command line by executing the following command:
 
 +---+
-mvn install -DskipITs
+mvn install -DskipTests
 +---+
 
  Since <<<skipTests>>> is also supported by the ${thatPlugin} Plugin, this will have the effect
  of not running any tests.  If, instead, you want to skip only the integration tests
  being run by the ${thisPlugin} Plugin, you would use the <<<skipITs>>> property instead:
 
 +---+
 mvn install -DskipITs
 +---+

Please either merge or close this PR instead of leaving it hanging.

[eolivelli]

I believe that this correction is valid. Merging.
thank you @qerub