Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @{...} property evaluation for the argLine. #30

Merged
merged 2 commits into from
Dec 20, 2013

Conversation

hgschmie
Copy link
Contributor

Replaces expressions @{property-name} in the argLine with the
corresponding properties from the model. This allows late evaluation
of property values when the plugin is executed (as compared to
evaluation when the pom is parsed as is done with ${property-name}
expressions).

This allows other plugins to modify or set properties with the changes
getting picked up by surefire.

Replaces expressions @{property-name} in the argLine with the
corresponding properties from the model. This allows late evaluation
of property values when the plugin is executed (as compared to
evaluation when the pom is parsed as is done with ${property-name}
expressions).

This allows other plugins to modify or set properties with the changes
getting picked up by surefire.
@agudian
Copy link
Member

agudian commented Dec 18, 2013

Nice feature! And it even comes with an extended documentation. 👍

Would you please also create an issue for this in the Surefire-Jira and link your PR there?
Also, an Integration test is required (a new one or extending an existing one, e.g. the ForkCountIT). If you need some assistance there, let me know.

Thanks,
Andreas

@hgschmie
Copy link
Contributor Author

added integration tests. They pass fine for me when running

mvn -Dit.test=ArgLinePropertiesIT clean install

The whole test suite does not work for me on Linux using Java 7-86_64 (it crashes with an OutOfMemoryException), but the current master behaves the same. :-)

@hgschmie
Copy link
Contributor Author

@asfgit asfgit merged commit 4683d4d into apache:master Dec 20, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants