Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SUREFIRE-2086] Management of temporary files #535

Merged
merged 1 commit into from Jun 3, 2022
Merged

[SUREFIRE-2086] Management of temporary files #535

merged 1 commit into from Jun 3, 2022

Conversation

spannm
Copy link
Contributor

@spannm spannm commented May 12, 2022

Management of temporary files in surefire into sub directories of the system's directory of temporary files to avoid bloating the temp directory root.

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace SUREFIRE-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean install).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@spannm
Copy link
Contributor Author

spannm commented May 31, 2022

hi @michael-o I've answered to the requested changes. Anything else that needs to be done before accepting this pull request?

@olamy
Copy link
Member

olamy commented Jun 1, 2022

@sman-81 not sure what you have done but this PR include plenty of non needed commits (already in master)
plenty of changes are not from you.
maybe you should rebase correctly from master. thanks

@spannm
Copy link
Contributor Author

spannm commented Jun 1, 2022

@sman-81 not sure what you have done but this PR include plenty of non needed commits (already in master) plenty of changes are not from you. maybe you should rebase correctly from master. thanks

@olamy I had done the rebase from master wrongly. Now it should be good. Could you please take another look?

@olamy olamy merged commit 559db4c into apache:master Jun 3, 2022
@spannm
Copy link
Contributor Author

spannm commented Jun 3, 2022

Thanks @olamy!

@spannm spannm deleted the sman-81-SUREFIRE-2086-temp-file-management branch July 9, 2022 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants