Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SUREFIRE-2240] Don't manage JUnit5 artifact versions #725

Merged
merged 1 commit into from
Mar 7, 2024
Merged

[SUREFIRE-2240] Don't manage JUnit5 artifact versions #725

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 0 additions & 8 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,14 +308,6 @@
<version>${jacocoVersion}</version>
<classifier>runtime</classifier>
</dependency>
<dependency>
<!-- Do not upgrade, leads to test failures, needs analysis -->
<groupId>org.junit</groupId>
<artifactId>junit-bom</artifactId>
<version>5.9.3</version>
<type>pom</type>
<scope>import</scope>
</dependency>
</dependencies>
</dependencyManagement>
<dependencies>
Expand Down
10 changes: 10 additions & 0 deletions surefire-providers/surefire-junit-platform/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,13 @@
<tag>surefire-3.0.0-M8</tag>
</scm>

<properties>
<!-- common version suffix by platform and other junit5 artifacts, compare with https://github.com/junit-team/junit5/blob/main/gradle.properties -->
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcphilipp Is the assumption right that they always share the same suffix?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's correct but I'd feel more comfortable if this didn't have to be known here. Why didn't it work out with the BOM?

Copy link
Member Author

@kwin kwin Mar 7, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The BOM will affect transitive dependencies of overridden plugin dependencies, and therefore leads to incompatible versions/prevents updating the engine

<junit5VersionSuffix>9.3</junit5VersionSuffix>
<junit5Version>5.${junit5VersionSuffix}</junit5Version>
<junitPlatformVersion>1.${junit5VersionSuffix}</junitPlatformVersion>
</properties>

<dependencies>
<dependency>
<groupId>org.apache.maven.surefire</groupId>
Expand All @@ -89,15 +96,18 @@
<dependency>
<groupId>org.junit.platform</groupId>
<artifactId>junit-platform-launcher</artifactId>
<version>${junitPlatformVersion}</version>
</dependency>
<dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter-engine</artifactId>
<version>${junit5Version}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter-params</artifactId>
<version>${junit5Version}</version>
<scope>test</scope>
</dependency>
<dependency>
Expand Down