Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WAGON-618] Remove HTTP file listing with JSoup #79

Closed
wants to merge 1 commit into from

Conversation

michael-o
Copy link
Member

@michael-o michael-o commented Dec 18, 2021

@hboutemy
Copy link
Member

hboutemy commented Dec 19, 2021

short question: what is the user-visible effect?

longer form: I suppose no user knows that JSoup is used somewhere to list the content of a remote HTTP directory. Until now, it was magically working, sometimes...
Now that the API will always not work (consistently), is there a user visible output? something like a warning ("listing files on HTTP server xxx is not supported"), or an exception?

And basic question: does it only affect the getFileList(String) Wagon API for HTTP providers? https://maven.apache.org/wagon/wagon-provider-api/apidocs/org/apache/maven/wagon/Wagon.html#getFileList-java.lang.String-

@michael-o
Copy link
Member Author

short question: what is the user-visible effect?

Exception on a call.

longer form: I suppose no user knows that JSoup is used somewhere to list the content of a remote HTTP directory. Until now, it was magically working, sometimes... Now that the API will always not work (consistently), is there a user visible output? something like a warning ("listing files on HTTP server xxx is not supported"), or an exception?

Yes, UnsupportedOperationException will be thrown with an appropriate message.

And basic question: does it only affect the getFileList(String) Wagon API for HTTP providers? https://maven.apache.org/wagon/wagon-provider-api/apidocs/org/apache/maven/wagon/Wagon.html#getFileList-java.lang.String-

Yes, only. HTTP. Everything else continues to work.

@hboutemy
Copy link
Member

nice, I love the clear message, thank you

@michael-o
Copy link
Member Author

Merged into master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants