[MWRAPPER-103] Workaround: demote check to Warning

[cstamas]

For start, instead to die off, let's demote the failure to warning level.

---

https://issues.apache.org/jira/browse/MWRAPPER-103

[cstamas]

@gsmet eyes please. Disclaimer: I am not Win guy, so if you can bring on someone to verify, please do so.

[cstamas]

@jorsol eyes please

[jorsol]

The issue affects the wrapperSha256Sum from mvnw, not only-mvnw, actually the only-mvnw does not validate the wrapperSha256Sum since it doesn't download the jar.

In the end, this is not the fix for the issue reported, the trouble is that only-mvnw does different things than mvnw, so it seems that using only-mvnw works and mvnw don't.

[cstamas]

Oh, got it now. Ok, am closing this one out then, as I missed the topic.

[jorsol]

Since the default is now only-mvnw, maybe the current workaround is to simply remove the lines from:

maven-wrapper/maven-wrapper-distribution/src/resources/mvnw.cmd

Lines 156 to 172 in c9a3e67

	@REM If specified, validate the SHA-256 sum of the Maven wrapper jar file
	SET WRAPPER_SHA_256_SUM=""
	FOR /F "usebackq tokens=1,2 delims==" %%A IN ("%MAVEN_PROJECTBASEDIR%\.mvn\wrapper\maven-wrapper.properties") DO (
	IF "%%A"=="wrapperSha256Sum" SET WRAPPER_SHA_256_SUM=%%B
	)
	IF NOT %WRAPPER_SHA_256_SUM%=="" (
	powershell -Command "&{"^
	"$hash = (Get-FileHash \"%WRAPPER_JAR%\" -Algorithm SHA256).Hash.ToLower();"^
	"If('%WRAPPER_SHA_256_SUM%' -ne $hash){"^
	" Write-Error 'Error: Failed to validate Maven wrapper SHA-256, your Maven wrapper might be compromised.';"^
	" Write-Error 'Investigate or delete %WRAPPER_JAR% to attempt a clean download.';"^
	" Write-Error 'If you updated your Maven version, you need to update the specified wrapperSha256Sum property.';"^
	" exit 1;"^
	"}"^
	"}"
	if ERRORLEVEL 1 goto error
	)

Or comment the if ERRORLEVEL 1 goto error (not sure if this is enough).

[cstamas]

Yup, that is my problem as well: "not sure" 😄

[cstamas]

Next attempt: #132