Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MWRAPPER-132][MWRAPPER-124] port MWRAPPER-124 fix to only-script #133

Merged
merged 1 commit into from
Apr 18, 2024
Merged

[MWRAPPER-132][MWRAPPER-124] port MWRAPPER-124 fix to only-script #133

merged 1 commit into from
Apr 18, 2024

Conversation

gzm55
Copy link
Contributor

@gzm55 gzm55 commented Apr 18, 2024 •
edited by cstamas

port pr #120

Test Method:

sed -n '/public class Downloader/,/\t}/p' maven-wrapper-distribution/src/resources/only-mvnw > Downloader.java
jenv shell 21 ## or 1.7, 1.8, 11, 17
javac -version
javac Downloader.java -Xlint:all -Werror

Passed lint compile test with jdk 1.7, 1.8, 11, 17 and 21

https://issues.apache.org/jira/browse/MWRAPPER-132

@cstamas cstamas changed the title [MWRAPPER-124] port MWRAPPER-124 fix to only-script [MWRAPPER-132][MWRAPPER-124] port MWRAPPER-124 fix to only-script Apr 18, 2024
@cstamas cstamas merged commit c4c09a3 into apache:master Apr 18, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cstamas cstamas cstamas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@gzm55 @cstamas