Added missing @Deprecated/@deprecated annotations

@deprecated annotatio is helpful to prevent usage of deprecated API. For example: developer can see crossed out method/field name if this item is deprecated.
apache · Mar 8, 2023 · 6f548e5 · 6f548e5
1 parent ad74f9e
commit 6f548e5
Show file tree

Hide file tree

Showing 9 changed files with 13 additions and 3 deletions.
diff --git a/maven-compat/src/main/java/org/apache/maven/profiles/DefaultProfileManager.java b/maven-compat/src/main/java/org/apache/maven/profiles/DefaultProfileManager.java
@@ -67,6 +67,7 @@ public class DefaultProfileManager
      * @deprecated without passing in the system properties, the SystemPropertiesProfileActivator will not work
      *             correctly in embedded environments.
      */
+    @Deprecated
     public DefaultProfileManager( PlexusContainer container )
     {
         this( container, null );

diff --git a/maven-compat/src/main/java/org/apache/maven/project/InvalidProjectModelException.java b/maven-compat/src/main/java/org/apache/maven/project/InvalidProjectModelException.java
@@ -44,6 +44,7 @@ public InvalidProjectModelException( String projectId, String message, File pomL
      * @param validationResult
      * @deprecated use {@link File} constructor for pomLocation
      */
+    @Deprecated
     public InvalidProjectModelException( String projectId, String pomLocation, String message,
                                          ModelValidationResult validationResult )
     {
@@ -64,6 +65,7 @@ public InvalidProjectModelException( String projectId, String message, File pomF
      * @param message
      * @deprecated use {@link File} constructor for pomLocation
      */
+    @Deprecated
     public InvalidProjectModelException( String projectId, String pomLocation, String message )
     {
         this( projectId, message, new File( pomLocation ) );

diff --git a/...-compat/src/main/java/org/apache/maven/project/inheritance/ModelInheritanceAssembler.java b/...-compat/src/main/java/org/apache/maven/project/inheritance/ModelInheritanceAssembler.java
@@ -24,7 +24,6 @@
 
 /**
  * @author Jason van Zyl
- * @deprecated
  */
 @Deprecated
 public interface ModelInheritanceAssembler

diff --git a/...ain/java/org/apache/maven/project/interpolation/AbstractStringBasedModelInterpolator.java b/...ain/java/org/apache/maven/project/interpolation/AbstractStringBasedModelInterpolator.java
@@ -126,6 +126,7 @@ public Model interpolate( Model model, Map<String, ?> context )
      *
      * @deprecated Use {@link ModelInterpolator#interpolate(Model, File, ProjectBuilderConfiguration, boolean)} instead.
      */
+    @Deprecated
     public Model interpolate( Model model, Map<String, ?> context, boolean strict )
         throws ModelInterpolationException
     {

diff --git a/maven-compat/src/main/java/org/apache/maven/project/interpolation/ModelInterpolator.java b/maven-compat/src/main/java/org/apache/maven/project/interpolation/ModelInterpolator.java
@@ -40,12 +40,14 @@ public interface ModelInterpolator
     /**
      * @deprecated Use {@link ModelInterpolator#interpolate(Model, File, ProjectBuilderConfiguration, boolean)} instead.
      */
+    @Deprecated
     Model interpolate( Model project, Map<String, ?> context )
         throws ModelInterpolationException;
 
     /**
      * @deprecated Use {@link ModelInterpolator#interpolate(Model, File, ProjectBuilderConfiguration, boolean)} instead.
      */
+    @Deprecated
     Model interpolate( Model model, Map<String, ?> context, boolean strict )
         throws ModelInterpolationException;
 

diff --git a/maven-core/src/main/java/org/apache/maven/lifecycle/mapping/DefaultLifecycleMapping.java b/maven-core/src/main/java/org/apache/maven/lifecycle/mapping/DefaultLifecycleMapping.java
@@ -35,6 +35,7 @@ public class DefaultLifecycleMapping
     private Map<String, Lifecycle> lifecycleMap;
 
     /** @deprecated use lifecycles instead */
+    @Deprecated
     private Map<String, LifecyclePhase> phases;
 
     /**

diff --git a/maven-core/src/main/java/org/apache/maven/project/DuplicateProjectException.java b/maven-core/src/main/java/org/apache/maven/project/DuplicateProjectException.java
@@ -38,6 +38,7 @@ public class DuplicateProjectException
     /**
      * @deprecated use {@link #DuplicateProjectException(String, File, File, String)}
      */
+    @Deprecated
     public DuplicateProjectException( String message )
     {
         this( null, null, null, message );
@@ -46,6 +47,7 @@ public DuplicateProjectException( String message )
     /**
      * @deprecated use {@link #DuplicateProjectException(String, File, File, String)}
      */
+    @Deprecated
     public DuplicateProjectException( String message, Exception e )
     {
         super( message, e );

diff --git a/maven-core/src/main/java/org/apache/maven/project/ProjectBuildingException.java b/maven-core/src/main/java/org/apache/maven/project/ProjectBuildingException.java
@@ -85,6 +85,7 @@ public File getPomFile()
     /**
      * @deprecated use {@link #getPomFile()}
      */
+    @Deprecated
     public String getPomLocation()
     {
         if ( getPomFile() != null )

diff --git a/maven-core/src/main/java/org/apache/maven/toolchain/java/DefaultJavaToolChain.java b/maven-core/src/main/java/org/apache/maven/toolchain/java/DefaultJavaToolChain.java
@@ -26,10 +26,11 @@
  * Provides backwards compatibility with Maven 3.2.3 and earlier. Clients that do not require compatibility with Maven
  * 3.2.3 and earlier are encouraged to use {@link JavaToolchainImpl}.
  * <strong>Note:</strong> This is an internal component whose interface can change without prior notice.
- * 
+ *
  * @deprecated clients that do not require compatibility with Maven 3.2.3 and earlier should link to
  *             {@link JavaToolchainImpl} instead.
  */
+@Deprecated
 public class DefaultJavaToolChain
     extends JavaToolchainImpl
 {
@@ -52,4 +53,4 @@ public void setJavaHome( String javaHome )
         super.setJavaHome( javaHome );
     }
 
-}
+}