[MNG-7774] Maven config and command line interpolation #1097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is "mild introduction" of subset of new Maven4 features into Maven 3.9.x land, with single intent: be able to store resolver configuration along with checked in project sources in SCM. Changes: * interpolate properties and arguments * introduce two new special properties "session.rootDirectory" and "session.topDirectory" * these two properties may be undefined (the .mvn may not be found) * these two properties if undefined, but referenced during interpolation, causes Maven to bail out (error out), and will prevent starting. * some other minor cosmetic cleanup --- https://issues.apache.org/jira/browse/MNG-7774
| } | ||
| } else { | ||
| if (!isMultiModuleProjectDirectoryAcceptable(cliRequest.multiModuleProjectDirectory)) { | ||
| cliRequest.multiModuleProjectDirectory = null; |
There was a problem hiding this comment.
Will be ok that multiModuleProjectDirectory will be null.?
What other impact it can have?
There was a problem hiding this comment.
This PR corrects this: if not found .mvn folder, it will be null, yes, before it could have any contents. This makes it more consistent than before, when it could contain any path...
|
superseded by #1098 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is "mild introduction" of subset of new Maven4 features into Maven 3.9.x land, with single intent: be able to store resolver configuration along with checked in project sources in SCM.
Changes:
https://issues.apache.org/jira/browse/MNG-7774