[MNG-7792] Use a standalone asm version #1126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnodet
changed the title
|
Hm, locally ITs pass on me, unsure why they failed here. |
|
Restarted ITs.... |
cstamas
approved these changes
Aug 3, 2023
|
The failing IT uses this agent, and I'd look into it https://github.com/apache/maven-integration-testing/blob/master/core-it-support/core-it-javaagent/src/main/java/org/apache/maven/coreits/javaagent/mng5669/Premain.java |
Fixed with apache/maven-integration-testing#290 |
gnodet
force-pushed
the
MNG-7792-standalone-asm
branch
from
31cbfc9
to
4f3a85a
Compare
gnodet
force-pushed
the
MNG-7792-standalone-asm
branch
from
4f3a85a
to
bf574b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've extracted the use of a standalone ASM version as JDK 17 support is already covered by the upgrade to 0.9.0.M2.
To support JDK >= 19, we need ASM 9.5 and we thus need to use a standalone version of ASM and upgrade it.
This is a follow-up to #1119