[MNG-7846] Break out of endless loop #1206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there is a loop in throwable causes, DefaultExceptionHandler falls into an endless loop to produce message. Use plain hashSet to gather processed throwable instances to break out. --- https://issues.apache.org/jira/browse/MNG-7846
gnodet
approved these changes
Jul 19, 2023
…ementations? That override getCause but does not perform checks to what it was inited as "this" means "not yet inited" actually.
gnodet
approved these changes
Jul 19, 2023
cstamas
added a commit
to cstamas/maven
that referenced
this pull request
Jul 19, 2023
This is most probably "just" about broken Throwable implementations. Some override getCause but does not perform checks to what it was inited as "this" means "not yet inited" actually. Backport of 36db1e3 --- https://issues.apache.org/jira/browse/MNG-7846
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is a loop in throwable causes, DefaultExceptionHandler falls into an endless loop to produce message. Use plain hashSet to gather processed throwable instances to break out.
https://issues.apache.org/jira/browse/MNG-7846