[MNG-7893] Allow versioning the superpom according to the model version #1253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cstamas
reviewed
Sep 21, 2023
| @@ -495,6 +495,7 @@ private void validatePrerequisitesForNonMavenPluginProjects(List<MavenProject> p | |||
| * @return A {@link Set} of profile identifiers, never {@code null}. | |||
| */ | |||
| private Set<String> getAllProfiles(MavenSession session) { | |||
| // TODO: which version of super pom should we use here ? | |||
There was a problem hiding this comment.
Maybe the same version that project uses? But: what happens if reactor has multiple versions (not same)? -- IMHO should fail.
There was a problem hiding this comment.
I've update this part of the computation to be coherent with the way superPoms are used during model building. The superPom of a given project is determined by the modelVersion of that project and not the modelVersion of its upper parent. What this means is that if you write a 4.1.0 project which inherit a 4.0.0 parent, the superPom will be 4.1.0.
cstamas
approved these changes
Sep 21, 2023
cstamas
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA issue: https://issues.apache.org/jira/browse/MNG-7893
Btw, I wonder if the recent changes such as #1139 and #1085 should be updated to only affect the 4.1.0 superpom... Thoughts welcomed.