[MNG-7899] Various memory usage improvements 5 #1270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastien-doyon
changed the title
sebastien-doyon
force-pushed
the
MNG-7899_-_5
branch
2 times, most recently
from
c03db56
to
722c64a
Compare
gnodet
reviewed
Sep 28, 2023
sebastien-doyon
force-pushed
the
MNG-7899_-_5
branch
from
722c64a
to
ac35e69
Compare
gnodet
requested changes
Oct 19, 2023
maven-slf4j-provider/src/main/java/org/slf4j/impl/MavenSimpleLogger.java
Outdated
Show resolved
Hide resolved
maven-slf4j-provider/src/main/java/org/slf4j/impl/MavenSimpleLogger.java
Outdated
Show resolved
Hide resolved
sebastien-doyon
force-pushed
the
MNG-7899_-_5
branch
from
93599de
to
ceaf0a2
Compare
Multiple optimizations : - renderLevel() method use static constants instead of rebuilding the strings on each call - replace + operator usage with more PrintStream.print() calls to reduce temporary strings creation - reduce usage of MessageBuilder.a() method usage with more PrintStream.print() calls to reduce temporary strings creation - replace the builder() method with a static import
- Reduce PrintStream.print() calls - replace String.format with a simple string concat to reduce memory allocation (garbage)
- Change static constants to class member in MavenSimpleLogger - Add a setLength(int) method in MessageBuilder to enable reuse
sebastien-doyon
force-pushed
the
MNG-7899_-_5
branch
from
2f95a2a
to
6888b8e
Compare
gnodet
reviewed
Oct 20, 2023
api/maven-api-core/src/main/java/org/apache/maven/api/services/MessageBuilder.java
Show resolved
Hide resolved
gnodet
requested changes
Oct 20, 2023
maven-slf4j-provider/src/main/java/org/slf4j/impl/MavenSimpleLogger.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/MNG-7899
Multiple optimizations :
strings on each call
temporary strings creation
PrintStream.print() calls to reduce temporary strings creation
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
[X ] I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
[X ] In any other case, please file an Apache Individual Contributor License Agreement.