New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MNG-7933] configure strict artifact descriptor policy via property #1304
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is good, but we do have many other related changes pending, so let's merge this one to not get forgotten.
See #1301
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could add some documentation describing these configurations, which would otherwise be scattered all over the place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it correct issue number: https://issues.apache.org/jira/browse/MNG-5378 - Use maven-shared-utils in Maven core to replace plexus-utils
@@ -373,6 +375,12 @@ public DefaultRepositorySystemSession newRepositorySession(MavenExecutionRequest | |||
session.getRepositoryListener(), new ReverseTreeRepositoryListener())); | |||
} | |||
|
|||
boolean strictDescriptorPolicy = | |||
ConfigUtils.getBoolean(session, false, "aether.artifactDescriptorPolicy.strict"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not something like maven....
for this property?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i was just following conventions for setting aether / resolver properties from here: https://maven.apache.org/resolver/configuration.html
@jaredstehler I'd like to propose to have this PR superseded by "onSessionClose" that contains a bunch of maven+resolver improvements, for example this one (contains your change but exposed via CLI): e93bb72 |
@cstamas that looks perfect, thanks! PR for reference: #1301 |
386c74d
to
75c76c2
Compare
Is this PR still needed? Please close it out if not. |
This adds a mechanism for setting a strict artifact descriptor policy, via a boolean config property:
aether.artifactDescriptorPolicy.strict
.Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MNG-XXX] SUMMARY
,where you replace
MNG-XXX
andSUMMARY
with the appropriate JIRA issue.[MNG-XXX] SUMMARY
.Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message.
mvn clean verify
to make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.