Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNG-7933] configure strict artifact descriptor policy via property #1304

Closed

Conversation

jaredstehler
Copy link

@jaredstehler jaredstehler commented Nov 14, 2023

This adds a mechanism for setting a strict artifact descriptor policy, via a boolean config property: aether.artifactDescriptorPolicy.strict.

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MNG-XXX] SUMMARY,
    where you replace MNG-XXX and SUMMARY with the appropriate JIRA issue.
  • Also format the first line of the commit message like [MNG-XXX] SUMMARY.
    Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@jaredstehler jaredstehler marked this pull request as ready for review November 14, 2023 16:31
Copy link
Member

@cstamas cstamas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is good, but we do have many other related changes pending, so let's merge this one to not get forgotten.

See #1301

Copy link
Member

@CrazyHZM CrazyHZM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could add some documentation describing these configurations, which would otherwise be scattered all over the place.

Copy link
Member

@slawekjaranowski slawekjaranowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it correct issue number: https://issues.apache.org/jira/browse/MNG-5378 - Use maven-shared-utils in Maven core to replace plexus-utils

@@ -373,6 +375,12 @@ public DefaultRepositorySystemSession newRepositorySession(MavenExecutionRequest
session.getRepositoryListener(), new ReverseTreeRepositoryListener()));
}

boolean strictDescriptorPolicy =
ConfigUtils.getBoolean(session, false, "aether.artifactDescriptorPolicy.strict");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not something like maven.... for this property?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i was just following conventions for setting aether / resolver properties from here: https://maven.apache.org/resolver/configuration.html

@cstamas
Copy link
Member

cstamas commented Nov 15, 2023

@jaredstehler I'd like to propose to have this PR superseded by "onSessionClose" that contains a bunch of maven+resolver improvements, for example this one (contains your change but exposed via CLI): e93bb72

@jaredstehler jaredstehler changed the title [MNG-5378] configure strict artifact descriptor policy via property [MNG-7933] configure strict artifact descriptor policy via property Nov 15, 2023
@jaredstehler
Copy link
Author

jaredstehler commented Nov 15, 2023

@jaredstehler I'd like to propose to have this PR superseded by "onSessionClose" that contains a bunch of maven+resolver improvements, for example this one (contains your change but exposed via CLI): e93bb72

@cstamas that looks perfect, thanks! PR for reference: #1301

@cstamas
Copy link
Member

cstamas commented Dec 16, 2023

Is this PR still needed? Please close it out if not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants