Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNG-7906] Add unit test #1396

Closed
wants to merge 4 commits into from
Closed

[MNG-7906] Add unit test #1396

wants to merge 4 commits into from

Conversation

gnodet
Copy link
Contributor

@gnodet gnodet commented Feb 1, 2024

This PR currently provides 3 unit tests for MNG-7906.
The first two tests (testManagedDependencyBeforeImport and testManagedDependencyAfterImport) work in an expected way, i.e. the managed dependency defined in the POM is the one used.
The third one (testManagedDependencyTwoImports) is the problematic one, showing that the algorithm used to resolve conflicting managed dependencies is almost (apart from the two first tests) a "first wins" and not a "last wins" or even better a "closest then last wins".

It was proposed to add a WARNING when such conflict happens.

@gnodet
Copy link
Contributor Author

gnodet commented Feb 1, 2024

I've added the improved unit tests to #1370 instead.

@gnodet gnodet closed this Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant