Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNG-6919] fix wrapper windows cmd scripts #353

Closed
wants to merge 2 commits into from

Conversation

gzm55
Copy link
Contributor

@gzm55 gzm55 commented May 24, 2020

new maven-wrapper inherits 2 bugs for windows batch scripts:

  • correct file ending for windows cmd scripts
  • download.cmd should parse the config file

This pr is ported from takari/maven-wrapper#161.

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MNG-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MNG-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

* correct file ending for windows cmd scripts
* download.cmd should parse the config file
@gzm55 gzm55 changed the title [MVN-6919] fix wrapper windows cmd scripts [MNG-6919] fix wrapper windows cmd scripts May 24, 2020
Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please drop the gitattributes changes

@gzm55
Copy link
Contributor Author

gzm55 commented May 24, 2020

please drop the gitattributes changes

can we make all the cmd scripts to crlf at the releasing stage?

@michael-o michael-o self-requested a review May 24, 2020 17:34
eol is fixed by assembly-plugin `lineEnding` settings.
@gzm55
Copy link
Contributor Author

gzm55 commented May 25, 2020

@michael-o
as @rfscholte comment in the issue, eol is fixed in assembly-plugin settings, so i revert the changes on all .gitattributes file.

@gzm55 gzm55 closed this May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants