Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mng 6957: Support Build Consumer while defining modules in reverse order #391

Closed
wants to merge 114 commits into from
Closed

Mng 6957: Support Build Consumer while defining modules in reverse order #391

wants to merge 114 commits into from

Commits on Oct 27, 2020

  1. MNG-6957: extract inherit

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    acaaf88 View commit details
    Browse the repository at this point in the history

  2. MNG-6957: remove model from inherit method

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    0a1cb05 View commit details
    Browse the repository at this point in the history

  3. Simplify code

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    121bd9e View commit details
    Browse the repository at this point in the history

  4. Get modules from fileModel, respect profiles (which can also contain … 

    …modules)
    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    a5e7ee6 View commit details
    Browse the repository at this point in the history

  5. Add activeExternalProfiles

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    208de10 View commit details
    Browse the repository at this point in the history

  6. No need to check getActiveExternalProfiles, can't contain modules

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    f03490b View commit details
    Browse the repository at this point in the history

  7. Moving up setters of result

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    2ed1627 View commit details
    Browse the repository at this point in the history

  8. No need to keep activeProfiles in ModelData

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    cbf6c29 View commit details
    Browse the repository at this point in the history

  9. result.setRawModel( modelId, rawModel ) can also be moved

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    a77383a View commit details
    Browse the repository at this point in the history

  10. lineage can just a Models

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    98afc31 View commit details
    Browse the repository at this point in the history

  11. Replace ModelSource with Source

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    598060d View commit details
    Browse the repository at this point in the history

  12. Make clear where rawModel and model should be used

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    e4cd759 View commit details
    Browse the repository at this point in the history

  13. Use rawModel to read get parent

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    30f4f3a View commit details
    Browse the repository at this point in the history

  14. pick up tmpModel from result

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    5a2b9b5 View commit details
    Browse the repository at this point in the history

  15. extract profiles from result

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    24109e0 View commit details
    Browse the repository at this point in the history

  16. verify superpom by id

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    3c5f811 View commit details
    Browse the repository at this point in the history

  17. check currentData by id

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    0a04f51 View commit details
    Browse the repository at this point in the history

  18. ModelData.rawModel is never used

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    a324124 View commit details
    Browse the repository at this point in the history

  19. pick up inherited model from lineage

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    d486b4e View commit details
    Browse the repository at this point in the history

  20. Don't update ModelData

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    cb39b97 View commit details
    Browse the repository at this point in the history

  21. No need to change GAV for ModelData

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    3265c13 View commit details
    Browse the repository at this point in the history

  22. checkPluginVersions must use lineage

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    e7d2801 View commit details
    Browse the repository at this point in the history

  23. Split collecting raw models from inheritence

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    fa8de9c View commit details
    Browse the repository at this point in the history

  24. Set effectiveModel instance early

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    72c59d6 View commit details
    Browse the repository at this point in the history

  25. start reading poms witout parent

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    a655fe9 View commit details
    Browse the repository at this point in the history

  26. move effectivemodel to phase 2

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    7b244ae View commit details
    Browse the repository at this point in the history

  27. get activeExternalProfiles from result

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    a9e603c View commit details
    Browse the repository at this point in the history

  28. in case of root, pick up effectivepom from result

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    5ac87c4 View commit details
    Browse the repository at this point in the history

  29. some code is only required for non root

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    a044f10 View commit details
    Browse the repository at this point in the history

  30. poolbuilder can use effectivemodel

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    ac44aa9 View commit details
    Browse the repository at this point in the history

  31. move fileModel to result

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    6b6df5d View commit details
    Browse the repository at this point in the history

  32. properly assign effective model

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    0c61fdf View commit details
    Browse the repository at this point in the history

  33. Read modules from fileModel

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    87e735f View commit details
    Browse the repository at this point in the history

  34. During 2 phase builds use the fileModel

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    36ccdb7 View commit details
    Browse the repository at this point in the history

  35. Move setEffectiveModel

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    87abbb9 View commit details
    Browse the repository at this point in the history

  36. initProject after phase two

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    b00bd46 View commit details
    Browse the repository at this point in the history

  37. prepare rawModels for phase two builds

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    a32a6f7 View commit details
    Browse the repository at this point in the history

  38. pick up effective pom later

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    d914299 View commit details
    Browse the repository at this point in the history

  39. use fileModel for originalModel

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    81e93bd View commit details
    Browse the repository at this point in the history

  40. use pomFile as key of projectIndex

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    5520ac3 View commit details
    Browse the repository at this point in the history

  41. pick up pom from fileModel

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    628f50a View commit details
    Browse the repository at this point in the history

  42. Move rawModels to phase 2 

    No need for pre-init project anymore
    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    8b87e55 View commit details
    Browse the repository at this point in the history

  43. modelSource is never null

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    c4e216d View commit details
    Browse the repository at this point in the history

  44. Always look in cache for model

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    95b60a0 View commit details
    Browse the repository at this point in the history

  45. Use modelSource to set pomFile

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    3802003 View commit details
    Browse the repository at this point in the history

  46. use modelSource's inputStream to read model

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    ec90603 View commit details
    Browse the repository at this point in the history

  47. select severity based on modelSource instance

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    eeb49bc View commit details
    Browse the repository at this point in the history

  48. early check for fatal errors

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    136d396 View commit details
    Browse the repository at this point in the history

  49. extract readRawModel

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    48db31d View commit details
    Browse the repository at this point in the history

  50. Always use request.getModelSource() as cacheKey

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    aaa7067 View commit details
    Browse the repository at this point in the history

  51. always cache fileModel

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    20170b0 View commit details
    Browse the repository at this point in the history

  52. Split readRawModel from readModel

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    7191f91 View commit details
    Browse the repository at this point in the history

  53. put fileModel in cache when available

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    e173320 View commit details
    Browse the repository at this point in the history

  54. Use the same model

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    2a51bf1 View commit details
    Browse the repository at this point in the history

  55. improve moment of cloning

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    213bc84 View commit details
    Browse the repository at this point in the history

  56. Don't set pom on model

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    3d1270a View commit details
    Browse the repository at this point in the history

  57. ProjectBuilder should use rawModel because of its profile activations

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    93b5a01 View commit details
    Browse the repository at this point in the history

  58. directly set preferred source

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    b503507 View commit details
    Browse the repository at this point in the history

  59. No need to set the project file again

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    49ee2ae View commit details
    Browse the repository at this point in the history

  60. improve naming of variables

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    2f53b5b View commit details
    Browse the repository at this point in the history

  61. rawModels should be based on rawModel

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    7f79fdc View commit details
    Browse the repository at this point in the history

  62. rawModel most be activated, not the fileModel

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    2a46f8c View commit details
    Browse the repository at this point in the history

  63. switch methods

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    3e08457 View commit details
    Browse the repository at this point in the history

  64. Move readRawModel to phase 2

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    4c69a1f View commit details
    Browse the repository at this point in the history

  65. Use pomFile so context is used

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    a96a27a View commit details
    Browse the repository at this point in the history

  66. verify version after groupId+artifactId

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    a669e08 View commit details
    Browse the repository at this point in the history

  67. effective model should not be cached as raw model

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    3e6d30e View commit details
    Browse the repository at this point in the history

  68. rename method

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    d699e71 View commit details
    Browse the repository at this point in the history

  69. cache raw pom for inheritance

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    1ccd145 View commit details
    Browse the repository at this point in the history

  70. Move buildconsumer to phase 2

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    cc239b8 View commit details
    Browse the repository at this point in the history

  71. Use stream for collecting profile ids

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    68ad1a5 View commit details
    Browse the repository at this point in the history

  72. Combine methods to reduce cache

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    2b41e8d View commit details
    Browse the repository at this point in the history

  73. move readRawModel, is only used once

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    2c7a891 View commit details
    Browse the repository at this point in the history

  74. always return new result

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    dce61af View commit details
    Browse the repository at this point in the history

  75. Don't auto cast

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    daaf2f0 View commit details
    Browse the repository at this point in the history

  76. start moving call readFileModel

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    587df50 View commit details
    Browse the repository at this point in the history

  77. use rawModel for artifactId

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    33c2dc0 View commit details
    Browse the repository at this point in the history

  78. move readFileModel for parents

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    e1f9853 View commit details
    Browse the repository at this point in the history

  79. clean up code

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    6bc43be View commit details
    Browse the repository at this point in the history

  80. use result of readRawModel

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    2376951 View commit details
    Browse the repository at this point in the history

  81. TransformerContext must use ModelCache

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    847de5e View commit details
    Browse the repository at this point in the history

  82. Happy flow build consumer restored

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    2e55731 View commit details
    Browse the repository at this point in the history

  83. No need to cache temp raw model during phase 1

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    53bb4ed View commit details
    Browse the repository at this point in the history

  84. No need to reset getModelIds anymore

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    6e36900 View commit details
    Browse the repository at this point in the history

  85. Provide option key for transformerContext

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    f254871 View commit details
    Browse the repository at this point in the history

  86. inline code

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    7b4908d View commit details
    Browse the repository at this point in the history

  87. rename to readEffectiveModel, so we have all readXModel available

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    94a74e1 View commit details
    Browse the repository at this point in the history

  88. Remove pomFile parameter

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    ebb85d2 View commit details
    Browse the repository at this point in the history

  89. prepare reading unknown dependency from build/consumer pom

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    22038bc View commit details
    Browse the repository at this point in the history

  90. Fix early dependency reactor read for build/consumer

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    3224175 View commit details
    Browse the repository at this point in the history

  91. Fix buildconsumer for unknown parent

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    8bdd48a View commit details
    Browse the repository at this point in the history

  92. This can stay ModelBuildingRequest

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    3153d92 View commit details
    Browse the repository at this point in the history

  93. Remove redundant parameter of readFileModel

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    091eaf1 View commit details
    Browse the repository at this point in the history

  94. remove redundant parameter from readRawModel

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    d2e9e29 View commit details
    Browse the repository at this point in the history

  95. Introduce DefaultTransformerContext, initialized during build, immuta… 

    …ble during consume.
    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    9e2a32c View commit details
    Browse the repository at this point in the history

  96. Pass ModelBuildingRequest

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    8d071ed View commit details
    Browse the repository at this point in the history

  97. Refactor code

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    20f7067 View commit details
    Browse the repository at this point in the history

  98. Update documentation

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    eb406ff View commit details
    Browse the repository at this point in the history

  99. Add javadoc

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    7f39d05 View commit details
    Browse the repository at this point in the history

  100. Improve parentFilter, change requirement getRawModel by Path

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    b44c333 View commit details
    Browse the repository at this point in the history

  101. Extract interface, only DefaultModelBuilder should be aware of implem… 

    …entation of TransformerContextBuilder
    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    9638628 View commit details
    Browse the repository at this point in the history

  102. improve documentation, make tags name similar

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    faffc45 View commit details
    Browse the repository at this point in the history

  103. improve documentation

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    f3e8d97 View commit details
    Browse the repository at this point in the history

  104. fix merge

    @rfscholte
    rfscholte committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    b9607f0 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2020

  1. Merge branch 'master' into MNG-6957

    @rfscholte
    rfscholte committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    b6f0b12 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2020

  1. Merge branch 'master' into MNG-6957

    @rfscholte
    rfscholte committed Nov 28, 2020
    Configuration menu
    Copy the full SHA
    2737305 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2020

  1. Merge branch 'master' into MNG-6957

    @rfscholte
    rfscholte committed Nov 29, 2020
    Configuration menu
    Copy the full SHA
    337d180 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2020

  1. Merge branch 'master' into MNG-6957

    @rfscholte
    rfscholte committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    459ba0a View commit details
    Browse the repository at this point in the history

  2. Do not use the ReactorModelCache to store the mapping between GA<->So… 

    …urce
    @gnodet @rfscholte
    gnodet authored and rfscholte committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    50e8beb View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2020

  1. Adjustments based on review comments

    @rfscholte
    rfscholte committed Dec 13, 2020
    Configuration menu
    Copy the full SHA
    aab4950 View commit details
    Browse the repository at this point in the history

  2. Adjustments based on review comments

    @rfscholte
    rfscholte committed Dec 13, 2020
    Configuration menu
    Copy the full SHA
    db89566 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2020

  1. Adjustments based on review comments

    @rfscholte
    rfscholte committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    a1de191 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into MNG-6957

    @rfscholte
    rfscholte committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    6f7f5be View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2020

  1. Remove unused innerclass

    @rfscholte
    rfscholte committed Dec 21, 2020
    Configuration menu
    Copy the full SHA
    e686be7 View commit details
    Browse the repository at this point in the history