New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MNG-7129] http repo refactoring for java8 #617
[MNG-7129] http repo refactoring for java8 #617
Conversation
…epo-java8 to MNG-7129/master-db * commit '6aeeea1d1dfcf4ceb7ded6350d31fb957c2b8eea': [MNG-7129] Rework http repo to java 8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that this entire code needs to be rewritten to use Wagon instead of manually fiddling with HttpClient
.
* commit '8b3b955ea4f24f68e6d30e4e979ae7341e0bbb6b': [MNG-7129] Rework http repo to java 8
good point and should not be a big deal. will try to do it in following prs |
Not necessarily instead, but a simple abstraction layer would allow to use the default http repository or use wagon as an alternative and more versatile provider. |
Agree. It could be reworked as we like in the future, just at this point it will be a small cleanup which doesnt have much of implications. also, it was tested, so it will be great to merge it. Conceptually i agree with more comprehensive rework in future |
I'm going to merge. What's the reasoning for using an |
Hi. The rationale is that cache misses are natural. Optionals allow to isolate normal flow from real errors (like transport and format issues) and to avoid flood of not so useful "not found" exceptions. If it is necessary to assert a resource presence it should be done in cache logic by a caller |
Cache repositories refactoring for java8 - using optionals instead of nullables
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MNG-XXX] - Fixes bug in ApproximateQuantiles
,where you replace
MNG-XXX
with the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verify
to make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.