Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNG-7129] http repo refactoring for java8 #617

Merged
merged 4 commits into from Nov 25, 2021

Conversation

AlexanderAshitkin
Copy link

@AlexanderAshitkin AlexanderAshitkin commented Nov 23, 2021

Cache repositories refactoring for java8 - using optionals instead of nullables

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MNG-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MNG-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

Alexander Ashitkin added 2 commits November 23, 2021 12:31
…epo-java8 to MNG-7129/master-db

* commit '6aeeea1d1dfcf4ceb7ded6350d31fb957c2b8eea':
  [MNG-7129] Rework http repo to java 8
Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that this entire code needs to be rewritten to use Wagon instead of manually fiddling with HttpClient.

Alexander Ashitkin added 2 commits November 23, 2021 13:54
* commit '8b3b955ea4f24f68e6d30e4e979ae7341e0bbb6b':
  [MNG-7129] Rework http repo to java 8
@AlexanderAshitkin
Copy link
Author

I believe that this entire code needs to be rewritten to use Wagon instead of manually fiddling with HttpClient.

good point and should not be a big deal. will try to do it in following prs

@gnodet
Copy link
Contributor

gnodet commented Nov 25, 2021

I believe that this entire code needs to be rewritten to use Wagon instead of manually fiddling with HttpClient.

good point and should not be a big deal. will try to do it in following prs

Not necessarily instead, but a simple abstraction layer would allow to use the default http repository or use wagon as an alternative and more versatile provider.

@AlexanderAshitkin
Copy link
Author

I believe that this entire code needs to be rewritten to use Wagon instead of manually fiddling with HttpClient.

good point and should not be a big deal. will try to do it in following prs

Not necessarily instead, but a simple abstraction layer would allow to use the default http repository or use wagon as an alternative and more versatile provider.

Agree. It could be reworked as we like in the future, just at this point it will be a small cleanup which doesnt have much of implications. also, it was tested, so it will be great to merge it.

Conceptually i agree with more comprehensive rework in future

@gnodet
Copy link
Contributor

gnodet commented Nov 25, 2021

I believe that this entire code needs to be rewritten to use Wagon instead of manually fiddling with HttpClient.

good point and should not be a big deal. will try to do it in following prs

Not necessarily instead, but a simple abstraction layer would allow to use the default http repository or use wagon as an alternative and more versatile provider.

Agree. It could be reworked as we like in the future, just at this point it will be a small cleanup which doesnt have much of implications. also, it was tested, so it will be great to merge it.

Conceptually i agree with more comprehensive rework in future

I'm going to merge. What's the reasoning for using an Optional instead of throwing an exception ?

@gnodet gnodet merged commit c73b5e2 into apache:MNG-7129-master Nov 25, 2021
@AlexanderAshitkin
Copy link
Author

I'm going to merge. What's the reasoning for using an Optional instead of throwing an exception ?

Hi. The rationale is that cache misses are natural. Optionals allow to isolate normal flow from real errors (like transport and format issues) and to avoid flood of not so useful "not found" exceptions. If it is necessary to assert a resource presence it should be done in cache logic by a caller

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants