[master][MNG-7350] Introduce a factory for ModelCache #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnodet
changed the title
cstamas
approved these changes
Dec 3, 2021
Actually all these "extension points" should be componentized (if not already), for easier extension. |
|
Is https://github.com/apache/maven/pull/630/files#diff-50ddbca622e461d2056985a5c792fc4652574831f3a8b69da9be3a2f5af9e552R65 missing from here or I missed it? |
Fix missing javadoc and binding
Nice catch, I missed it because the module was renamed. I've also added a short javadoc on the two new classes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mvnddoes redefine a few maven classes in order to plugin its caching layer or change some behaviours, but this is sometime very difficult without copying some core class entirely.One of those class is the
ProjectBuilderand it's being reimplemented inmvndonly because theModelCacheis created using a direct call on the implementation.This ticket aims to introduce a
ModelCacheFactoryso thatmvndcan simply define a custom factory instead of redefining the fullProjectBuilder.