Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNG-6326] Make the build fail if core extensions can not be loaded #648

Merged
merged 4 commits into from Jan 7, 2022

Conversation

gnodet
Copy link
Contributor

@gnodet gnodet commented Jan 4, 2022

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MNG-XXX] SUMMARY, where you replace MNG-XXX
    and SUMMARY with the appropriate JIRA issue. Best practice is to use the JIRA issue
    title in the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@michael-o
Copy link
Member

Does it make sense to provide an IT for that?

@gnodet
Copy link
Contributor Author

gnodet commented Jan 4, 2022

I did add an IT with apache/maven-integration-testing#133, but it works locally but not on github CI, not sure why yet...

@michael-o
Copy link
Member

I did add an IT with apache/maven-integration-testing#133, but it works locally but not on github CI, not sure why yet...

The test works for me correctly. Though I have noticed that Maven is terminated prematurely. I don't see the BUILD FAILURE output since this happens very early in the build. Do you think this can be reasonably improved?

@gnodet
Copy link
Contributor Author

gnodet commented Jan 7, 2022

I did add an IT with apache/maven-integration-testing#133, but it works locally but not on github CI, not sure why yet...

The test works for me correctly. Though I have noticed that Maven is terminated prematurely. I don't see the BUILD FAILURE output since this happens very early in the build. Do you think this can be reasonably improved?

No, the BUILD FAILURE and BUILD SUCCESS messages are displayed when the session ends. In our case, the exception is thrown before the session is even created.

@michael-o
Copy link
Member

I did add an IT with apache/maven-integration-testing#133, but it works locally but not on github CI, not sure why yet...

The test works for me correctly. Though I have noticed that Maven is terminated prematurely. I don't see the BUILD FAILURE output since this happens very early in the build. Do you think this can be reasonably improved?

No, the BUILD FAILURE and BUILD SUCCESS messages are displayed when the session ends. In our case, the exception is thrown before the session is even created.

Makes sense. Fail early, let's leave it like that.

@michael-o
Copy link
Member

Please apply to master as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants