Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNG-7570] Plugin descriptor can carry required Maven version #832

Merged
merged 1 commit into from Oct 19, 2022

Conversation

kwin
Copy link
Member

@kwin kwin commented Oct 18, 2022

Takes precedence over POMs Maven prerequisite

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MNG-XXX] SUMMARY, where you replace MNG-XXX
    and SUMMARY with the appropriate JIRA issue. Best practice is to use the JIRA issue
    title in the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@kwin kwin force-pushed the feature/maven-prerequisite-in-plugin-descriptor branch from ce57c6e to cd6e4e2 Compare October 18, 2022 10:50
Its value takes precedence over POMs Maven prerequisite
@kwin kwin force-pushed the feature/maven-prerequisite-in-plugin-descriptor branch from cd6e4e2 to ecd8592 Compare October 18, 2022 10:55
@kwin kwin merged commit daa8e16 into master Oct 19, 2022
@michael-o michael-o deleted the feature/maven-prerequisite-in-plugin-descriptor branch October 19, 2022 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants