Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MNG-7607] Add M4 Transport API #884

Merged
merged 10 commits into from Dec 1, 2022
Merged

[MNG-7607] Add M4 Transport API #884

merged 10 commits into from Dec 1, 2022

Conversation

cstamas
Copy link
Member

@cstamas cstamas commented Nov 28, 2022 •
edited

Something simple to use and would reuse all the auth/proxy etc data from Maven. Intentionally super-trivial API.

If something more "serious" needed, plugin should probably roll it's own solution.

https://issues.apache.org/jira/browse/MNG-7607

@cstamas
Add M4 Transport API
7659163 
Something simple to use and would reuse all the auth/proxy etc
data from Maven. Intentionally super-trivial API.

If something more "serious" needed, plugin should probably roll it's
own solution.
@cstamas cstamas self-assigned this Nov 28, 2022
@slawekjaranowski
Copy link
Member

Great idea, I see that we can cover one case when user want to download a custom resource from remote repository.

We also have another case when user want to download a custom resource from any remote url.
And also want to use authorization configuration from settings/servers and preserve settings/proxy for connections.

@cstamas
Copy link
Member Author

cstamas commented Nov 28, 2022 •
edited

One big remark I just noticed: m4 API uses Optional quite extensively, while I went with my own preference. Better to not mix things, and rework this with Optional? fixed, using Optional to be consistent with rest of API

@cstamas cstamas changed the title Add M4 Transport API [MNG-7607] Add M4 Transport API Nov 28, 2022
@cstamas cstamas marked this pull request as ready for review November 28, 2022 18:41
@cstamas
Copy link
Member Author

cstamas commented Nov 30, 2022

We also have another case when user want to download a custom resource from any remote url. And also want to use authorization configuration from settings/servers and preserve settings/proxy for connections.

@slawekjaranowski But user can create own new instance of RemoteRepository (using whatever values/url he wants), and use that. Or is that not feasible?

@cstamas cstamas merged commit f70b001 into apache:master Dec 1, 2022
@cstamas cstamas deleted the m4-transport-api branch December 1, 2022 12:53
@gnodet gnodet added this to the 4.0.0-alpha-3 milestone Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnodet gnodet gnodet approved these changes

Assignees

@cstamas cstamas

Labels
None yet
Projects
None yet
Milestone
4.0.0-alpha-3
3 participants
@cstamas @slawekjaranowski @gnodet