[MNG-7600] LocalRepositoryManager is created too early

[slawekjaranowski]

LocalRepositoryManager needs configurations from RepositorySystemSession so must be created after session configuration is finished.

(cherry picked from commit b1c1f75)

---

Following this checklist to help us incorporate your
contribution quickly and easily:

• Make sure there is a JIRA issue filed
  for the change (usually before you start working on it). Trivial changes like typos do not
  require a JIRA issue. Your pull request should address just this issue, without
  pulling in other changes.
• Each commit in the pull request should have a meaningful subject line and body.
• Format the pull request title like [MNG-XXX] SUMMARY, where you replace MNG-XXX
  and SUMMARY with the appropriate JIRA issue. Best practice is to use the JIRA issue
  title in the pull request title and in the first line of the commit message.
• Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
• Run mvn clean verify to make sure basic checks pass. A more thorough check will
  be performed on your pull request automatically.
• [ x] You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

• I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004

• In any other case, please file an Apache Individual Contributor License Agreement.

[michael-o]

LGTM, any ITs to port? As far as I understand MNG-7590 needs to go first?

[slawekjaranowski]

LGTM, any ITs to port? As far as I understand MNG-7590 needs to go first?

MNG-7590 is independent of this.

In 3.8.x we use resolver 1.6.3 so only one property is available for LRM - aether.enhancedLocalRepository.trackingFilename

There is not IT test for it 😞

[slawekjaranowski]

Looking again resolver 1.6.3 has a less configuration options, so maybe such ports are not required for 3.8.x

[michael-o]

Looking again resolver 1.6.3 has a less configuration options, so maybe such ports are not required for 3.8.x

Less != none. I also maintain a fork of 3.8.x with Resolver 1.8.x until 3.9.0 is settled: https://maven.apache.org/resolver/maven-3.8.x.html. I still think this is beneficial.

[slawekjaranowski]

Ok, we can merge as is, with agree for missing IT tests - what do you think?

I think that better idea will be write a unit tests for DefaultRepositorySystemSessionFactory#newRepositorySession, but it is another issue.

[michael-o]

Ok, we can merge as is, with agree for missing IT tests - what do you think?

I think that better idea will be write a unit tests for DefaultRepositorySystemSessionFactory#newRepositorySession, but it is another issue.

I agree.