Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNG-7669] Add artifact-type for Tycho #964

Open
wants to merge 1 commit into
base: maven-3.9.x
Choose a base branch
from

Conversation

laeubi
Copy link

@laeubi laeubi commented Jan 19, 2023

Since a while Tycho is going more and more "maven-like" so today even more Tycho artifacts approaching at maven-central.

In some circumstances this leads to strange problems, because Dependencies have a type (usually the packaging type) but artifacts have an extension (where different packaging types often map to the same extension), and maven only includes a few mappings by default users currently need to enable an extension so that this works.

This adds a new default mapping so this type can be used smoothly in maven.

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MNG-XXX] SUMMARY,
    where you replace MNG-XXX and SUMMARY with the appropriate JIRA issue.
  • Also format the first line of the commit message like [MNG-XXX] SUMMARY.
    Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@michael-o
Copy link
Member

I think this should be master first.

What about lifecycles?

@laeubi
Copy link
Author

laeubi commented Jan 19, 2023

I think this should be master first.

I can create one for master as well, but if its not accepted for 3.9 it does not make much sense to port it (as master is a bit different one can't just cherry pick it from there).

What about lifecycles?

The problem only arise if maven tries to resolve an artifact, lifecycle is not affected.

@michael-o
Copy link
Member

For me, this seems hardless. I'd like to know what others think. @gnodet @cstamas @hboutemy

Since a while Tycho is going more and more "maven-like" so today even
more Tycho artifacts approaching at maven-central.

In some circumstances this leads to strange problems, because
Dependencies have a type (usually the packaging type) but artifacts have
an extension (where different packaging types often map to the same
extension), and maven only includes a few mappings by default users
currently need to enable an extension so that this works.

This adds a new default mapping so this type can be used smoothly in
maven.
@laeubi
Copy link
Author

laeubi commented Jan 20, 2023

as @cstamas pointed out, only change in XML file would be required, I updated the PR.

@rmannibucau
Copy link
Contributor

-1 for me to get anything not org.apache.maven in maven core, in particular when test covering is 0 and this can break any time.
+1 to get it maintained where it belongs to only.

@michael-o
Copy link
Member

michael-o commented Feb 4, 2023

I wonder whether this could also be registered from .mvn/extensions.xml?! @cstamas WDYT?

@elharo elharo changed the title MNG-7669 - Add artifact-type for Tycho [MNG-7669] Add artifact-type for Tycho Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants