-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MNG-7669] Add artifact-type for Tycho #964
base: maven-3.9.x
Are you sure you want to change the base?
Conversation
I think this should be master first. What about lifecycles? |
I can create one for master as well, but if its not accepted for 3.9 it does not make much sense to port it (as master is a bit different one can't just cherry pick it from there).
The problem only arise if maven tries to resolve an artifact, lifecycle is not affected. |
Since a while Tycho is going more and more "maven-like" so today even more Tycho artifacts approaching at maven-central. In some circumstances this leads to strange problems, because Dependencies have a type (usually the packaging type) but artifacts have an extension (where different packaging types often map to the same extension), and maven only includes a few mappings by default users currently need to enable an extension so that this works. This adds a new default mapping so this type can be used smoothly in maven.
as @cstamas pointed out, only change in XML file would be required, I updated the PR. |
-1 for me to get anything not org.apache.maven in maven core, in particular when test covering is 0 and this can break any time. |
I wonder whether this could also be registered from |
Since a while Tycho is going more and more "maven-like" so today even more Tycho artifacts approaching at maven-central.
In some circumstances this leads to strange problems, because Dependencies have a type (usually the packaging type) but artifacts have an extension (where different packaging types often map to the same extension), and maven only includes a few mappings by default users currently need to enable an extension so that this works.
This adds a new default mapping so this type can be used smoothly in maven.
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MNG-XXX] SUMMARY
,where you replace
MNG-XXX
andSUMMARY
with the appropriate JIRA issue.[MNG-XXX] SUMMARY
.Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message.
mvn clean verify
to make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.