[MNG-7677] Maven slowness improvement #989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change is effectively in resolver 1.9.5, but there are other "low hanging fruits" like delegate created on a "hot method". --- https://issues.apache.org/jira/browse/MNG-7677
|
This PR will pass once apache/maven-resolver#245 is merged, built and deployed by Jenkins, and artifacts picked up by this PR. |
slawekjaranowski
approved these changes
Feb 15, 2023
|
After apache/maven-resolver#245 merged (and deployed by CI), restarted all the CI jobs on this PR, and they are expected to pass OK, as wrote above. |
cstamas
added a commit
to cstamas/maven
that referenced
this pull request
Feb 20, 2023
Of the resolver (downloading vs downloaded), just report after the fact it was downloaded (or failed to download), no need for double lines for same resource/dependency. This experiment includes apache#989 but does not affects it (just to create "closer" Maven to upcoming release). As one could expect, IT suite does fail with this change as some ITs do assert against the build logs (but the build itself did pass OK). Failing ITs: [ERROR] Failures: [ERROR] MavenITmng6240PluginExtensionAetherProvider.testPluginExtensionDependingOnMavenAetherProvider:83->AbstractMavenIntegrationTestCase.assertEquals:668->AbstractMavenIntegrationTestCase.assertEquals:673 expected: <2> but was: <0> [INFO] [ERROR] Tests run: 885, Failures: 1, Errors: 0, Skipped: 80 As to be expected, the IT asserts there is log line without progress (so DownloadING one, the one that is removed).
|
So this need to be a singleton? |
I'd rather say: given this class is stateless, it CAN be singleton/shared/reused, instead to be re-instantiated for each call of this "hot" method. |
I see, makes sense. No reason to create new objects all the time. |
cstamas
changed the title
asfgit
pushed a commit
that referenced
this pull request
Mar 9, 2023
The crux was in resolver 1.9.5, but there are other "low hanging fruits" like delegate created on a "hot method". --- https://issues.apache.org/jira/browse/MNG-7677
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The crux was in resolver 1.9.5, but there are other "low hanging fruits" like delegate created on a "hot method".
https://issues.apache.org/jira/browse/MNG-7677