Fixed parsing of ld.so.cache on new glibc. #384
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For me it looks fine. How about @asekretenko ? |
|
FWIW it's breaking other things: |
@cf-natali Did you run this test in the same machine with the other tests (like In another hand, there are a couple of places in |
|
On Sat, 29 May 2021, 14:24 Qian Zhang, ***@***.***> wrote:
FWIW it's breaking other things:
[ RUN ] HealthCheckTest.ROOT_HealthyTaskWithContainerImage
../../src/tests/health_check_tests.cpp:505: Failure
(testImage).failure(): Failed to create docker test image rootfs: Failed to parse ld.so cache: Invalid format
[ FAILED ] HealthCheckTest.ROOT_HealthyTaskWithContainerImage (26 ms)
@cf-natali <https://github.com/cf-natali> Did you run this test in the
same machine with the other tests (like LdcacheTest.Parse), all of these
tests will call ldcache::parse() internally, so it does not make sense
that one succeeds but the other fails.
I'm not sure what you mean - this test is an example of failing tests,
among many others.
In another hand, there are a couple of places in ldcache::parse() which
will error out with Invalid format, maybe we should use distinct error
message in each places so that we can better troubleshooting this issue.
Dunno, the issue seems pretty clear to me, it affects anything parsing
ldcache due to the format change. And the attached change fixes it.
—
… You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#384 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB75O43IY5HF3SVBGXFFSS3TQDTIZANCNFSM443EOPDA>
.
|
qianzhangxa
reviewed
May 29, 2021
NVM, I thought |
cf-natali
force-pushed
the
charles-ldcache-new-format
branch
from
1c348e3
to
82b79ad
Compare
Aha no worries it happens! I think all comments are addressed now, let me know if you need anything else :). |
|
Ah and by the way, here's how I tested it:
|
qianzhangxa
reviewed
May 30, 2021
Just posted a minor comment, otherwise I think we are good to merge :) |
Since glibc 2.32, ld.so.cache now defaults to the "new" format, instead of the "compat" format which was in use since glibc 2.2 (around 20 years ago). Closes #10220.
cf-natali
force-pushed
the
charles-ldcache-new-format
branch
from
82b79ad
to
3fb0b1f
Compare
|
The commit in this PR has been merged, and I also marked https://issues.apache.org/jira/browse/MESOS-10220 as resolved, thanks @cf-natali for your contribution! |
Lqp1
pushed a commit
to criteo-forks/mesos
that referenced
this pull request
Feb 23, 2024
Since glibc 2.32, `ld.so.cache` now defaults to the "new" format, instead of the "compat" format which was in use since glibc 2.2 (around 20 years ago). It is now the default on e.g. Debian bullseye, and any recent Linux distribution. The code change adds support for the "new" format along with the existing support for the "compat". Before: ``` root@thinkpad:/home/cf/src/mesos/build# ldconfig -c new root@thinkpad:/home/cf/src/mesos/build# ./bin/mesos-tests.sh --gtest_filter=*Ld* [...] [==========] Running 4 tests from 2 test cases. [----------] Global test environment set-up. [----------] 1 test from LdcacheTest [ RUN ] LdcacheTest.Parse ../../src/tests/ldcache_tests.cpp:43: Failure cache: Invalid format [ FAILED ] LdcacheTest.Parse (0 ms) [----------] 1 test from LdcacheTest (0 ms total) [----------] 3 tests from Ldd [ RUN ] Ldd.BinSh ../../src/tests/ldd_tests.cpp:43: Failure cache: Invalid format [ FAILED ] Ldd.BinSh (0 ms) [ RUN ] Ldd.EmptyCache [ OK ] Ldd.EmptyCache (1 ms) [ RUN ] Ldd.MissingFile ../../src/tests/ldd_tests.cpp:77: Failure cache: Invalid format [ FAILED ] Ldd.MissingFile (0 ms) [----------] 3 tests from Ldd (1 ms total) [----------] Global test environment tear-down [==========] 4 tests from 2 test cases ran. (8 ms total) [ PASSED ] 1 test. [ FAILED ] 3 tests, listed below: [ FAILED ] LdcacheTest.Parse [ FAILED ] Ldd.BinSh [ FAILED ] Ldd.MissingFile 3 FAILED TESTS ``` After: ``` root@thinkpad:/home/cf/src/mesos/build# ldconfig -c new root@thinkpad:/home/cf/src/mesos/build# ./bin/mesos-tests.sh --gtest_filter=*Ld* [...] [==========] Running 4 tests from 2 test cases. [----------] Global test environment set-up. [----------] 1 test from LdcacheTest [ RUN ] LdcacheTest.Parse [ OK ] LdcacheTest.Parse (529 ms) [----------] 1 test from LdcacheTest (529 ms total) [----------] 3 tests from Ldd [ RUN ] Ldd.BinSh [ OK ] Ldd.BinSh (3 ms) [ RUN ] Ldd.EmptyCache [ OK ] Ldd.EmptyCache (0 ms) [ RUN ] Ldd.MissingFile [ OK ] Ldd.MissingFile (0 ms) [----------] 3 tests from Ldd (3 ms total) [----------] Global test environment tear-down [==========] 4 tests from 2 test cases ran. (541 ms total) [ PASSED ] 4 tests. ``` This closes apache#384 (cherry picked from commit 9598db0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since glibc 2.32,
ld.so.cachenow defaults to the "new" format, insteadof the "compat" format which was in use since glibc 2.2 (around 20 years
ago). It is now the default on e.g. Debian bullseye, and any recent Linux
distribution.
The code change adds support for the "new" format along with the existing
support for the "compat".
Before:
After:
Closes #10220.
@asekretenko @andreaspeters