Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add framework plugin #405

Closed
wants to merge 1 commit into from
Closed

Add framework plugin #405

wants to merge 1 commit into from

Conversation

andreaspeters
Copy link
Contributor

As I mentioned, I add a framework plugin to mesos-cli and some new features for the already existing task plugin.

The features are:

  • show all framework
  • inspect frameworks and tasks
  • disable the limitation of tasks in the task list

@cf-natali
Copy link
Contributor

Hey,

I'm on holiday so I'll have a look when I'm back, unless someone else beats me to it.

@andreaspeters
Copy link
Contributor Author

😂 Take your time and enjoy your holiday.

cf-natali
cf-natali reviewed Sep 2, 2021
View reviewed changes
Copy link
Contributor

@cf-natali cf-natali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to split the changes to the task plugin into its own MR.

src/python/cli_new/lib/cli/http.py Show resolved Hide resolved
src/python/cli_new/lib/cli/http.py Show resolved Hide resolved
@andreaspeters
Copy link
Contributor Author

I think it would be better to split the changes to the task plugin into its own MR.

Oh please don't push me to split it. :-( Thats very painfull. There will be more PR's for the mesos-cli in the future. Then I will keep an eye to separate it.

@cf-natali
Copy link
Contributor

I think it would be better to split the changes to the task plugin into its own MR.

Oh please don't push me to split it. :-( Thats very painfull. There will be more PR's for the mesos-cli in the future. Then I will keep an eye to separate it.

Really?
The problem is that fundamentally this MR contains two unrelated changes, so it'd be nice to separate.
Either to review, commit, and revert if necessary...

@andreaspeters
ADD: get framework information.
0a894b0 
ADD: inspect task to get low level information of a task.

ADD: framework plugin.

ADD: framework filter for tasks.

CHANGE: task query limit to unlimited.

remove newline and rewrite docstring
@andreaspeters
Copy link
Contributor Author

andreaspeters commented Sep 2, 2021 •
edited

I think it would be better to split the changes to the task plugin into its own MR.

Oh please don't push me to split it. :-( Thats very painfull. There will be more PR's for the mesos-cli in the future. Then I will keep an eye to separate it.

Really?
The problem is that fundamentally this MR contains two unrelated changes, so it'd be nice to separate.
Either to review, commit, and revert if necessary...

Charles u are killing me. 😂 But I will do it because u are right.

@andreaspeters
Copy link
Contributor Author

andreaspeters commented Sep 3, 2021 •
edited

Shell I open three PR's? Technically there are three kind of changes.

  1. Add Framework Plugins
  2. Update Task Plugins
  3. Update mesos_cli lib.

What do u think?

@cf-natali
Copy link
Contributor

Sounds good!

@cf-natali
Copy link
Contributor

@andreaspeters how's the refactoring going? :)

@andreaspeters
Copy link
Contributor Author

@andreaspeters how's the refactoring going? :)

Didn't found the time the last week. Hopefully the next two weeks.

@andreaspeters andreaspeters mentioned this pull request Sep 21, 2021
Merged
@andreaspeters andreaspeters mentioned this pull request Oct 25, 2021
Merged
@cf-natali
Copy link
Contributor

@andreaspeters I'm closing this one since you've split it into separate MRs.

@cf-natali cf-natali closed this Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cf-natali cf-natali cf-natali left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@andreaspeters @cf-natali