This repository has been archived by the owner on Jun 29, 2021. It is now read-only.
Fix for encoding error when using InputStreams #104
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis error seems unrelated. |
| @@ -244,7 +227,7 @@ private static File createFileFromInputStream(InputStream inputStream, String en | |||
| file = fileCandidate; | |||
|
|
|||
| final BufferedWriter writer = FileHelper.getBufferedWriter(file, encoding); | |||
| final BufferedReader reader = new BufferedReader(new InputStreamReader(inputStream)); | |||
| final BufferedReader reader = new BufferedReader(new InputStreamReader(inputStream, Charset.forName(encoding))); | |||
There was a problem hiding this comment.
For the sake of consistency, would it be nicer to use FileHelper.getBufferedReader(inputStream, encoding)?
|
Sorry for the long wait - I didn't realize that you had changed the branch since my remark. +1 and let's merge! :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://issues.apache.org/jira/browse/METAMODEL-1086