This repository has been archived by the owner on Jun 29, 2021. It is now read-only.
Feature/jdbc composite relations #149
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PK/FK relations are not correctly resolved, they are returned as a pairwise, cartesian product of their keys. Test is in H2 database as SQL is used here, the problem should appear in all DBMS though.
…irwise listing of the columns
|
The solution looks good to me, but it's not really following our code conventions. Because of the small size, I can fix that up before patching, so no problem. But I see you're taking on a few other PRs too, so maybe it's good for you to pick up our code formatting rules etc. to avoid issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for METAMODEL-1145.
The test might not be in the best location.