METAMODEL-86: Allow transactional querying in JDBC update scripts #164
Conversation
|
Update: I found a way to unit test this and a good thing I did too. The approach I had built wasn't really working since the query method I used closed connection. That's fixed now. Furthermore the unit test revealed that such update scripts can easily cause deadlocks at the DB level. These will be rolled back, but the client needs a good way to catch them, which is why I added the |
| return (JdbcDataContext) super.getDataContext(); | ||
| public final DataContext getDataContext() { | ||
| final Connection connection = getConnection(); | ||
| return new JdbcUpdateCallbackDataContext(getJdbcDataContext(), connection); |
There was a problem hiding this comment.
Ok, this hack took me a while before I got the idea :-) Clever trick how to make the associated DataContext use our connection
There was a problem hiding this comment.
Clever good or clever bad? :-) Are we good to merge you think?
There was a problem hiding this comment.
it is fine I think, it was just neutral observation ;-)
|
Now I checked the rest. Also executed few tests on real database:
Code looks fine, I recommend merge :-) |
Here's my attempt at solving METAMODEL-86. I wasn't sure how to test it so ... It's not really tested, except existing tests should pass obviously. Review accordingly, please :-)