METAMODEL-1205: Made CassandraUnit based test skip on JDK 9+ #195
Conversation
It seems that CassandraUnit simply does not work on JDK 9+, see related comments in the code. For now I've added a JUnit `Assume` call which ensures that the test code is skipped when CassandraUnit fails to come up. Eventually, when they fix CassandraUnit, we should be able to upgrade the CassandraUnit dependency and it would presumably start working again.
|
Some exploding SLF4J bindings. |
|
D'oh! Seems cassandra unit now requires the use of logback classic. That's kinda lame, but I'll switch it out for the test scope at least. |
|
Note the "Update" in my PR description above. A lot more dependencies have been updated in this MR now to resolve JAR hell conflicts.. |
|
Code LGTM (I could comment on the files with only cosmetic changes, but I wont... -ish :)). Not sure what I can test. I never used Cassandra, and I don't (currently) have Java 9+ or anything Hadoop. But I If anything specifically you want me to check (also if it means playing around with Hadoop, Cassandra or Java 9+), let me know. |
|
I don't think we need additional testing here - the CassandraUnit tests still run on Travis CI (just not in JDK9 builds) |
The actual code using guava class CharMatcher was removed in PR apache#195 (METAMODEL-1205) But the guava dependency is still part of POM. Since the dependency is no more required removing the same
It seems that CassandraUnit simply does not work on JDK 9+, see related comments in the code. For now I've added a JUnit
Assumecall which ensures that the test code is skipped when CassandraUnit fails to come up. Eventually, when they fix CassandraUnit, we should be able to upgrade the CassandraUnit dependency and it would presumably start working again.Update: This PR now also updates versions of: Guava, Hadoop, HBase, Jackson and SLF4j. I got into a situation with Cassandra Unit and Cassandra itself requiring a newer Guava, which then required an upgrade of Hadoop, which then required an update of HBase. Hurray for JAR hell. Luckily it seems to work just fine when everything is on latest and greatest versions. And as a developer I quite prefer that anyway. Should set us on a better path to support JDK 9, 10 and 11.