This repository has been archived by the owner on Jun 29, 2021. It is now read-only.
METAMODEL-1151: Fixed by adding DataContextFactory for SugarCRM. #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LosD
suggested changes
Jul 22, 2019
There was a problem hiding this comment.
Mostly LGTM; a single typo which I guess should be fixed, as well as a few comments (but none of them a blocker at all, just me being pedantic 😄).
I haven't tested, but this type of code is pretty much works-or-not, and I guess you already took it for a quick spin.
sugarcrm/src/main/java/org/apache/metamodel/sugarcrm/SugarCrmDataContextFactory.java
Outdated
Show resolved
Hide resolved
dynamodb/src/main/java/org/apache/metamodel/dynamodb/DynamoDbDataContextFactory.java
Outdated
Show resolved
Hide resolved
|
Thanks for the review @LosD, I love that you're obnoxiously pedantic and detail oriented ;-) I corrected the PR as per your feedback items. |
|
It's what I do 😄 LGTM! Will merge when I'm back at my computer (you can of course also just do it now if you prefer) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per https://issues.apache.org/jira/browse/METAMODEL-1151 only SugarCRM was missing a DataContextFactory, so I added it :-)