This repository has been archived by the owner on May 12, 2021. It is now read-only.
METRON-1866: Improve metron-bro-plugin-kafka documentation #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
nickwallen
reviewed
Nov 9, 2018
There was a problem hiding this comment.
Thanks @JonZeolla . This looks really good. Just one suggestion for the end of the bro-pkg instructions.
| Installed "bro/apache/metron-bro-plugin-kafka" (master) | ||
| Loaded "bro/apache/metron-bro-plugin-kafka" | ||
| ``` | ||
|
|
There was a problem hiding this comment.
I think it would be good to add the same sanity check that we have at the end of the manual installation instructions, as the last step here.
[root@localhost ~]# bro -N Apache::Kafka
Apache::Kafka - Writes logs to Kafka (dynamic, version 0.3)
There was a problem hiding this comment.
Sounds good, added a final step to validate manually. Initially, I left that out since bro-pkg does a very similar test, among others
README.md
Outdated
| * You can also filter IPv6 logs from within your Metron cluster [using Stellar](https://github.com/apache/metron/tree/master/metron-stellar/stellar-common#is_ip). In that case, you wouldn't apply a predicate in your bro configuration, and instead Stellar would filter the logs out before they were processed by the enrichment layer of Metron. | ||
| * It is also possible to use the `is_v6_subnet()` bro function in your predicate, as of their [2.5 release](https://www.bro.org/sphinx-git/install/release-notes.html#bro-2-5), however the above example should work on [bro 2.4](https://www.bro.org/sphinx-git/install/release-notes.html#bro-2-4) and newer, which has been the focus of the kafka plugin. | ||
|
|
||
| ## Settings | ||
|
|
||
| ### `kafka_conf` | ||
| ### `logs_to_send` |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
JonZeolla
force-pushed
the
METRON-1866
branch
from
ac86aca
to
3313e18
Compare
|
+1 |
JonZeolla
added a commit
to JonZeolla/metron-bro-plugin-kafka
that referenced
this pull request
Nov 10, 2018
…via jonzeolla) closes apache#17
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor Comments
This depends on METRON-1304. Pure documentation change