METRON-1563 : Base Stellar assign for feature branch #1014
Conversation
|
@cestella I rebased this on the new feature branch ( after rebasing on the same master ) and I get all of these other commits. I don't know how to get rid of them? |
=, +=, -=, *=, /= This are valid for assignment to variables. All assignments return the value assigned, as other scripting languages do. VariableResolver extended with an update() method, though it may not be supported by all resolvers, this gives the ability to update variables and save between calls. The shell was updated for this, such that assignment calls More testing need and doc but I wanted to get it out there. This is dependent on PR 686
fixes for handling validate with null values
ottobackwards
force-pushed
the
stellar_assign
branch
from
2e94e14
to
1aee767
Compare
|
ok, @cestella I have fixed up the feature branch and this pr so it is clean |
|
Should assignment be |
Ultimately, I'd like to see us move to supporting It looks like I am not sure how this PR impacts all the places where Stellar is used and assignment might already occur; field transforms, enrichment, REPL, profiler, etc. There is some other way in which assignment is handled in at least some of these places. I imagine that we would need to update these to use the new mechanism here? Or maybe that is left to a future PR? |
Sorry, its a little hard to digest that old PR, but I think from this comment, @ottobackwards is saying that all the other touch points would be updated in a future PR on this feature branch. |
In my opinion we should support both for at least a release. |
|
Do we want to expand assignment to |
|
Can I ask how we do ++, --, += etc with the := notation? |
|
I wonder if it's good enough just to keep |
|
I'll expand the assignment to include := in literal stellar, maybe that will bump some review |
|
ok, I updated the feature base to track master, and pulled that into this. |
|
Ok, this looks good. +1 to go to the feature branch |
|
This is in, not sure why it isn't closed |
|
@ottobackwards If it's a feature branch, the PR on Github doesn't automatically close. It only happens for merges into a master. It's a bit annoying, but I'm not sure there's a whole lot to do about it |
repackage:
#687
Please sanity check and see that PR