This repository has been archived by the owner on May 12, 2021. It is now read-only.
METRON-1603: Fix multivalue field errors in Bro Solr schema #1051
Closed
mmiklavc
wants to merge
1
commit into
apache:feature/METRON-1416-upgrade-solr
from
mmiklavc:fix-schema-multivalued
Closed
METRON-1603: Fix multivalue field errors in Bro Solr schema #1051
mmiklavc
wants to merge
1
commit into
apache:feature/METRON-1416-upgrade-solr
from
mmiklavc:fix-schema-multivalued
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing I have proper unit tests, but you can validate the change by manually piping data into Metron.
|
I tested this in full dev and was able to index these messages without issue. Thanks for fixing this! +1 |
Closing this as merged in the feature branch. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor Comments
https://issues.apache.org/jira/browse/METRON-1603
Ran some sample from our unit testing infrastructure that pointed out some shortcomings in the Bro schema not revealed by our standard sensor-stub data that's setup by default as a service for demo purposes in full dev. For Bro records that have multi-valued fields (i.e. an array of values), you will see an exception when indexing in Solr if the collection does not explicitly set multiValued=true for that field.
I modified the Solr schema check integration test data to flex all of the multi-valued fields I found properly.
Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification Guidelines for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
For all changes:
For code changes:
Have you included steps to reproduce the behavior or problem that is being changed or addressed?
Have you included steps or a guide to how the change may be verified and tested manually?
Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
Have you written or updated unit tests and or integration tests to verify your changes?
Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
For documentation related changes:
n/a
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.