METRON-1635: Alerts UI status update doesn't immediately show up

[merrimanr]

Contributor Comments

This PR changes the behavior of the Alerts UI by applying alert status updates optimistically. The approach is similar to the change in #1077. I also changed the process of renaming a metaalert to be optimistic as well since it follows the same pattern. I'm happy to split that off into a separate PR.

Changes Included

• Refactored the getData method by moving logic to update an alert to it's own method.
• Removed the toggleAlertEditor parameter from the getData function. This should be called separately in my opinion.
• Moved redundant code to a single updateAlertState function
• Updated the alert update process to immediately apply the update to the UI and revert to the previous state when an update fails.
• Updated the metaalert name update process to immediately apply the update to the UI and revert to the previous state when an update fails.

Testing

This has been tested in full dev. Navigate to the Alerts UI and open the details panel for an alert. Changing the status of an alert should be reflected in the UI immediately. To test the case of an error being returned from the back end, I stopped the REST application and then tried to change the alert status. You should see the alert status change for no more than a split second before reverting to the previous state. The name change fix can also be tested this way by creating a metaalert and changing the name.

Pull Request Checklist

Thank you for submitting a contribution to Apache Metron.
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification Guidelines for complete smoke testing guides.

In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:

For all changes:

• Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
• Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
• Has your PR been rebased against the latest commit within the target branch (typically master)?

For code changes:

• Have you included steps to reproduce the behavior or problem that is being changed or addressed?

• Have you included steps or a guide to how the change may be verified and tested manually?

• Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:

  mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh 
  

• Have you written or updated unit tests and or integration tests to verify your changes?

• If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

• Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?

For documentation related changes:

• Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via site-book/target/site/index.html:

  cd site-book
  mvn site
  

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.

[sardell]

+1 Tested changing the alert status and the meta alert name on full-dev. The UI behavior is exactly as described above.

[tiborm]

Reviewed +1

[cestella]

+1 by inspection