This repository has been archived by the owner on May 12, 2021. It is now read-only.
METRON-1705 Create ProfilePeriod Using Period ID [Feature Branch] #1148
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases you need to be able to create a
ProfilerPeriod
using an epoch timestamp. In other cases, you need to be able to create one using the period ID. The period ID is a monotonically increasing value which uniquely identifies each profile period.Since both an epoch timestamp and a period ID are
Long
s, I created two separate factory methods to create aProfilePeriod
rather than using a public constructor directly. This makes it much more clear as to the intended purpose.ProfilePeriod.fromTimestamp
ProfilePeriod.fromPeriodId
This is a pull request against the
METRON-1699-create-batch-profiler
feature branch.Testing
Pull Request Checklist